From: Jan Kara <jack@suse.cz>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Theodore Tso <tytso@mit.edu>,
"Darrick J . Wong" <djwong@kernel.org>, Jan Kara <jack@suse.cz>,
Zorro Lang <zlang@kernel.org>,
linux-ext4@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH] ext4: return error on syncfs after shutdown
Date: Wed, 4 Sep 2024 12:37:03 +0200 [thread overview]
Message-ID: <20240904103703.cwp6jw3vd2cu3szc@quack3> (raw)
In-Reply-To: <20240904084657.1062243-1-amir73il@gmail.com>
On Wed 04-09-24 10:46:57, Amir Goldstein wrote:
> This is the logic behavior and one that we would like to verify
> using a generic fstest similar to xfs/546.
>
> Link: https://lore.kernel.org/fstests/20240830152648.GE6216@frogsfrogsfrogs/
> Suggested-by: Darrick J. Wong <djwong@kernel.org>
> Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Yeah, makes sense to me. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
>
> Ted,
>
> Please see the discussion about moving test xfs/546 to generic.
>
> WDYT?
>
> Thanks,
> Amir.
>
> fs/ext4/super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index e72145c4ae5a..b9cf18819e11 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -6279,7 +6279,7 @@ static int ext4_sync_fs(struct super_block *sb, int wait)
> struct ext4_sb_info *sbi = EXT4_SB(sb);
>
> if (unlikely(ext4_forced_shutdown(sb)))
> - return 0;
> + return -EIO;
>
> trace_ext4_sync_fs(sb, wait);
> flush_workqueue(sbi->rsv_conversion_wq);
> --
> 2.34.1
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2024-09-04 10:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 8:46 [PATCH] ext4: return error on syncfs after shutdown Amir Goldstein
2024-09-04 10:37 ` Jan Kara [this message]
2024-11-07 15:12 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240904103703.cwp6jw3vd2cu3szc@quack3 \
--to=jack@suse.cz \
--cc=amir73il@gmail.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox