From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20C2F20E06D; Wed, 25 Sep 2024 12:09:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727266148; cv=none; b=tOVbSIFRwzY7ZGm8zWBI0bY7DBmvqbQ/T0Fx1kYAvug3HoqFfbQRQII3WdmjZYyxBCmpgedVXewd9WIuNpFyj9xr8Kxu3ggl2+PpnQ0fCX/P9n4RRyz3QBdZAhjtMm5uf5CQpnWCpeLVgArUicv2H75lRt3NUmUd+RQ1kER86fo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727266148; c=relaxed/simple; bh=KxKgC5AVnCmGX4gStU//FRcLXEDEgMAAdXF++34WPvw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HDA+plx8lWpLbNXL0J7FGTw9+1VCGwY+rm5k5rrivqFGfpDdTLb9F7CUuYqPO30KrGsizhMkOjyoBJlx2vCRdWnlCGi8hnsXpPWN0I8rOPHkVlmyTyYmjBqmd/cIiqcLm+TcH9ZnVxQumbnUAORzm65HKWSomP7+wG4VMESfVLA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BcvdSJb2; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BcvdSJb2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A2D63C4CECF; Wed, 25 Sep 2024 12:09:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727266147; bh=KxKgC5AVnCmGX4gStU//FRcLXEDEgMAAdXF++34WPvw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BcvdSJb2lyNub9NJXN8huZRpjZ/Ew7pnLf0v25FlWC4FUFUt+H9/fZbaD4cqOLfJL UQtUvntnSNMijAO4XF4X0YVNZKCsmCDcVbcw64YZHFYkfCsr9h4A6XnomWf7Q4ZVSL qSv2ZtS2cR6yxmSgkU4J09qRPbMrY69RIoEXV4jSa5ggd/2I4OShZAIkxbM89UN64b D9b5+jsWofNaFQQBtqmxU1P4RVCrklqaZAd+lGpWRRHuxX6oo5Qdhv9+2k1LfcMp6X bZSJok17eNEc8cLWPyh0q01XeepNRn0FQM9NfT7UCEJvSXrwP83NAlowet1n+4h6RE R+AuslWTId55g== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Thadeu Lima de Souza Cascardo , Theodore Ts'o , Sasha Levin , adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org Subject: [PATCH AUTOSEL 6.10 191/197] ext4: ext4_search_dir should return a proper error Date: Wed, 25 Sep 2024 07:53:30 -0400 Message-ID: <20240925115823.1303019-191-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240925115823.1303019-1-sashal@kernel.org> References: <20240925115823.1303019-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.10.11 Content-Transfer-Encoding: 8bit From: Thadeu Lima de Souza Cascardo [ Upstream commit cd69f8f9de280e331c9e6ff689ced0a688a9ce8f ] ext4_search_dir currently returns -1 in case of a failure, while it returns 0 when the name is not found. In such failure cases, it should return an error code instead. This becomes even more important when ext4_find_inline_entry returns an error code as well in the next commit. -EFSCORRUPTED seems appropriate as such error code as these failures would be caused by unexpected record lengths and is in line with other instances of ext4_check_dir_entry failures. In the case of ext4_dx_find_entry, the current use of ERR_BAD_DX_DIR was left as is to reduce the risk of regressions. Signed-off-by: Thadeu Lima de Souza Cascardo Link: https://patch.msgid.link/20240821152324.3621860-2-cascardo@igalia.com Signed-off-by: Theodore Ts'o Signed-off-by: Sasha Levin --- fs/ext4/namei.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c index 1311ad0464b2a..12af7c7e09c1a 100644 --- a/fs/ext4/namei.c +++ b/fs/ext4/namei.c @@ -1526,7 +1526,7 @@ static bool ext4_match(struct inode *parent, } /* - * Returns 0 if not found, -1 on failure, and 1 on success + * Returns 0 if not found, -EFSCORRUPTED on failure, and 1 on success */ int ext4_search_dir(struct buffer_head *bh, char *search_buf, int buf_size, struct inode *dir, struct ext4_filename *fname, @@ -1547,7 +1547,7 @@ int ext4_search_dir(struct buffer_head *bh, char *search_buf, int buf_size, * a full check */ if (ext4_check_dir_entry(dir, NULL, de, bh, search_buf, buf_size, offset)) - return -1; + return -EFSCORRUPTED; *res_dir = de; return 1; } @@ -1555,7 +1555,7 @@ int ext4_search_dir(struct buffer_head *bh, char *search_buf, int buf_size, de_len = ext4_rec_len_from_disk(de->rec_len, dir->i_sb->s_blocksize); if (de_len <= 0) - return -1; + return -EFSCORRUPTED; offset += de_len; de = (struct ext4_dir_entry_2 *) ((char *) de + de_len); } @@ -1707,8 +1707,10 @@ static struct buffer_head *__ext4_find_entry(struct inode *dir, goto cleanup_and_exit; } else { brelse(bh); - if (i < 0) + if (i < 0) { + ret = ERR_PTR(i); goto cleanup_and_exit; + } } next: if (++block >= nblocks) @@ -1802,7 +1804,7 @@ static struct buffer_head * ext4_dx_find_entry(struct inode *dir, if (retval == 1) goto success; brelse(bh); - if (retval == -1) { + if (retval < 0) { bh = ERR_PTR(ERR_BAD_DX_DIR); goto errout; } -- 2.43.0