From: Jan Kara <jack@suse.cz>
To: Ye Bin <yebin@huaweicloud.com>
Cc: tytso@mit.edu, adilger.kernel@dilger.ca,
linux-ext4@vger.kernel.org, jack@suse.cz,
zhangxiaoxu5@huawei.com
Subject: Re: [PATCH 1/5] jbd2: remove redundant judgments for check v1 checksum
Date: Thu, 26 Sep 2024 14:52:44 +0200 [thread overview]
Message-ID: <20240926125244.5l2ajllkdfcbpko5@quack3> (raw)
In-Reply-To: <20240918113604.660640-2-yebin@huaweicloud.com>
On Wed 18-09-24 19:36:00, Ye Bin wrote:
> From: Ye Bin <yebin10@huawei.com>
>
> 'need_check_commit_time' is only used by v2/v3 checksum, so there isn't
> need to add 'need_check_commit_time' judegement for v1 checksum logic.
>
> Signed-off-by: Ye Bin <yebin10@huawei.com>
Looks good. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/jbd2/recovery.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/jbd2/recovery.c b/fs/jbd2/recovery.c
> index 667f67342c52..5efbca6a98c4 100644
> --- a/fs/jbd2/recovery.c
> +++ b/fs/jbd2/recovery.c
> @@ -619,7 +619,6 @@ static int do_one_pass(journal_t *journal,
> if (pass != PASS_REPLAY) {
> if (pass == PASS_SCAN &&
> jbd2_has_feature_checksum(journal) &&
> - !need_check_commit_time &&
> !info->end_transaction) {
> if (calc_chksums(journal, bh,
> &next_log_block,
> --
> 2.31.1
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2024-09-26 12:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-18 11:35 [PATCH 0/5] some cleanup and refactor for jbd2 journal recover Ye Bin
2024-09-18 11:36 ` [PATCH 1/5] jbd2: remove redundant judgments for check v1 checksum Ye Bin
2024-09-26 12:52 ` Jan Kara [this message]
2024-09-18 11:36 ` [PATCH 2/5] jbd2: unified release of buffer_head in do_one_pass() Ye Bin
2024-09-26 12:57 ` Jan Kara
2024-09-18 11:36 ` [PATCH 3/5] jbd2: refactor JBD2_COMMIT_BLOCK process " Ye Bin
2024-09-26 13:01 ` Jan Kara
2024-09-18 11:36 ` [PATCH 4/5] jbd2: factor out jbd2_do_replay() Ye Bin
2024-09-26 13:24 ` Jan Kara
2024-09-18 11:36 ` [PATCH 5/5] jbd2: remove useless 'block_error' variable Ye Bin
2024-09-18 13:19 ` Zhang Yi
2024-09-26 13:19 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240926125244.5l2ajllkdfcbpko5@quack3 \
--to=jack@suse.cz \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=yebin@huaweicloud.com \
--cc=zhangxiaoxu5@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox