From: Jan Kara <jack@suse.cz>
To: Ye Bin <yebin@huaweicloud.com>
Cc: tytso@mit.edu, adilger.kernel@dilger.ca,
linux-ext4@vger.kernel.org, jack@suse.cz,
zhangxiaoxu5@huawei.com
Subject: Re: [PATCH v2 4/6] jbd2: factor out jbd2_do_replay()
Date: Mon, 30 Sep 2024 12:30:14 +0200 [thread overview]
Message-ID: <20240930103014.lf2bdwmbde2f2bu3@quack3> (raw)
In-Reply-To: <20240930005942.626942-5-yebin@huaweicloud.com>
On Mon 30-09-24 08:59:40, Ye Bin wrote:
> From: Ye Bin <yebin10@huawei.com>
>
> Factor out jbd2_do_replay() no funtional change.
>
> Signed-off-by: Ye Bin <yebin10@huawei.com>
Looks good. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Just one style nit below:
> + lock_buffer(nbh);
> + memcpy(nbh->b_data, obh->b_data, journal->j_blocksize);
> + if (flags & JBD2_FLAG_ESCAPE) {
> + *((__be32 *)nbh->b_data) =
> + cpu_to_be32(JBD2_MAGIC_NUMBER);
^^ this needs one more indent
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2024-09-30 10:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 0:59 [PATCH v2 0/6] some cleanup and refactor for jbd2 journal recover Ye Bin
2024-09-30 0:59 ` [PATCH v2 1/6] jbd2: remove redundant judgments for check v1 checksum Ye Bin
2024-09-30 2:36 ` Zhang Yi
2024-09-30 0:59 ` [PATCH v2 2/6] jbd2: unified release of buffer_head in do_one_pass() Ye Bin
2024-09-30 2:36 ` Zhang Yi
2024-09-30 0:59 ` [PATCH v2 3/6] jbd2: refactor JBD2_COMMIT_BLOCK process " Ye Bin
2024-09-30 2:37 ` Zhang Yi
2024-09-30 0:59 ` [PATCH v2 4/6] jbd2: factor out jbd2_do_replay() Ye Bin
2024-09-30 2:40 ` Zhang Yi
2024-09-30 10:30 ` Jan Kara [this message]
2024-09-30 0:59 ` [PATCH v2 5/6] jbd2: remove useless 'block_error' variable Ye Bin
2024-09-30 2:41 ` Zhang Yi
2024-09-30 0:59 ` [PATCH v2 6/6] jbd2: remove the 'success' parameter from the jbd2_do_replay() function Ye Bin
2024-09-30 2:43 ` Zhang Yi
2024-09-30 10:32 ` Jan Kara
2024-11-07 15:13 ` [PATCH v2 0/6] some cleanup and refactor for jbd2 journal recover Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240930103014.lf2bdwmbde2f2bu3@quack3 \
--to=jack@suse.cz \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=yebin@huaweicloud.com \
--cc=zhangxiaoxu5@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox