From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24C4A22B575; Fri, 4 Oct 2024 18:31:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728066677; cv=none; b=HFCG34EpmLCNZjXeVq2XOx+2FGWmYOzjz1GVjfix+g4Dh8ZEUcQbRM+hOVe00DGhj389CMtKPRb0nuRfMA7UhP1XxhVVgfWVGaYXAKlSEqwBrffJH56CoxdeH3gOSL1JR7sC4I8bFlzgxt6LbhcTis3pUT7QtEmBZVCykVJN0bE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728066677; c=relaxed/simple; bh=VM2bKstHBssTmDYg8lYezq5xIGxcCs8QM3oKIWQ9sn4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=uGsGjLWLcQvQThpEPy/iU6KY1A5U89ieHHXogHDE29T1QuemYXmuD4qzO198puq9PCMXw/8c/dTQhpHd7rY/TJUbVUWNDHF8au6/iDjtb1A/FDoFS2DDmaJlObh5ugtYd4d1XgSW786FMw5OU9hQcE+CeQmNq0K3qXYIHMMM1OU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=isdcDvh1; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="isdcDvh1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 38C66C4CEC6; Fri, 4 Oct 2024 18:31:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728066677; bh=VM2bKstHBssTmDYg8lYezq5xIGxcCs8QM3oKIWQ9sn4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=isdcDvh1erj/a76spmTlubi4FkkmlqIuvWPA26FUlPWAcY8mFn9lUU71r2FQOAwMH +yZQdmA5PEB6UIcAyOGJ2vHWylwqGPACr5lA3mGcRI8jKuc79sM0iGHpF3TiXJTJik IgvmJ7aN+mYYhVMth8SiHix5ZMeIId1p0mIAkKx7A0Had8io8Qwa3G+F/UZqbdjVwZ spOy6Yz6AlVtaWwCJbe3Q+KJV+h/jiUqP86SERWBpCO2UEQFsoLScpP2qEk0WjuNgI QsvI/788NDbbv/UMhHkYqZ0J1HJSaiED2wKf0r9NsmAUlnbk+I/QtX4Au+HmUz/bbY mxyANLDNILN5w== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Thadeu Lima de Souza Cascardo , Theodore Ts'o , Sasha Levin , adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 06/21] ext4: ext4_search_dir should return a proper error Date: Fri, 4 Oct 2024 14:30:41 -0400 Message-ID: <20241004183105.3675901-6-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241004183105.3675901-1-sashal@kernel.org> References: <20241004183105.3675901-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.4.284 Content-Transfer-Encoding: 8bit From: Thadeu Lima de Souza Cascardo [ Upstream commit cd69f8f9de280e331c9e6ff689ced0a688a9ce8f ] ext4_search_dir currently returns -1 in case of a failure, while it returns 0 when the name is not found. In such failure cases, it should return an error code instead. This becomes even more important when ext4_find_inline_entry returns an error code as well in the next commit. -EFSCORRUPTED seems appropriate as such error code as these failures would be caused by unexpected record lengths and is in line with other instances of ext4_check_dir_entry failures. In the case of ext4_dx_find_entry, the current use of ERR_BAD_DX_DIR was left as is to reduce the risk of regressions. Signed-off-by: Thadeu Lima de Souza Cascardo Link: https://patch.msgid.link/20240821152324.3621860-2-cascardo@igalia.com Signed-off-by: Theodore Ts'o Signed-off-by: Sasha Levin --- fs/ext4/namei.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c index e4fbc0f07eed2..dd795e10486b2 100644 --- a/fs/ext4/namei.c +++ b/fs/ext4/namei.c @@ -1417,7 +1417,7 @@ static inline bool ext4_match(const struct inode *parent, } /* - * Returns 0 if not found, -1 on failure, and 1 on success + * Returns 0 if not found, -EFSCORRUPTED on failure, and 1 on success */ int ext4_search_dir(struct buffer_head *bh, char *search_buf, int buf_size, struct inode *dir, struct ext4_filename *fname, @@ -1438,7 +1438,7 @@ int ext4_search_dir(struct buffer_head *bh, char *search_buf, int buf_size, * a full check */ if (ext4_check_dir_entry(dir, NULL, de, bh, search_buf, buf_size, offset)) - return -1; + return -EFSCORRUPTED; *res_dir = de; return 1; } @@ -1446,7 +1446,7 @@ int ext4_search_dir(struct buffer_head *bh, char *search_buf, int buf_size, de_len = ext4_rec_len_from_disk(de->rec_len, dir->i_sb->s_blocksize); if (de_len <= 0) - return -1; + return -EFSCORRUPTED; offset += de_len; de = (struct ext4_dir_entry_2 *) ((char *) de + de_len); } @@ -1596,8 +1596,10 @@ static struct buffer_head *__ext4_find_entry(struct inode *dir, goto cleanup_and_exit; } else { brelse(bh); - if (i < 0) + if (i < 0) { + ret = ERR_PTR(i); goto cleanup_and_exit; + } } next: if (++block >= nblocks) @@ -1691,7 +1693,7 @@ static struct buffer_head * ext4_dx_find_entry(struct inode *dir, if (retval == 1) goto success; brelse(bh); - if (retval == -1) { + if (retval < 0) { bh = ERR_PTR(ERR_BAD_DX_DIR); goto errout; } -- 2.43.0