From: Nicolas Bretz <bretznic@gmail.com>
To: tytso@mit.edu
Cc: linux-ext4@vger.kernel.org, Nicolas Bretz <bretznic@gmail.com>
Subject: [PATCH v2] ext4: inode: Delete braces for single statements
Date: Mon, 14 Oct 2024 07:06:54 -0700 [thread overview]
Message-ID: <20241014140654.69613-1-bretznic@gmail.com> (raw)
checkpatch.pl warnings - braces are not necessary
Removed trailing whitespaces introduced in v1
Signed-off-by: Nicolas Bretz <bretznic@gmail.com>
---
fs/ext4/inode.c | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 03c2253005f0..1c1c1ccc8a0c 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -440,11 +440,11 @@ static void ext4_map_blocks_es_recheck(handle_t *handle,
* could be converted.
*/
down_read(&EXT4_I(inode)->i_data_sem);
- if (ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS)) {
+ if (ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS))
retval = ext4_ext_map_blocks(handle, inode, map, 0);
- } else {
+ else
retval = ext4_ind_map_blocks(handle, inode, map, 0);
- }
+
up_read((&EXT4_I(inode)->i_data_sem));
/*
@@ -453,7 +453,7 @@ static void ext4_map_blocks_es_recheck(handle_t *handle,
*/
if (es_map->m_lblk != map->m_lblk ||
es_map->m_flags != map->m_flags ||
- es_map->m_pblk != map->m_pblk) {
+ es_map->m_pblk != map->m_pblk)
printk("ES cache assertion failed for inode: %lu "
"es_cached ex [%d/%d/%llu/%x] != "
"found ex [%d/%d/%llu/%x] retval %d flags %x\n",
@@ -461,7 +461,6 @@ static void ext4_map_blocks_es_recheck(handle_t *handle,
es_map->m_pblk, es_map->m_flags, map->m_lblk,
map->m_len, map->m_pblk, map->m_flags,
retval, flags);
- }
}
#endif /* ES_AGGRESSIVE_TEST */
@@ -547,11 +546,11 @@ int ext4_map_blocks(handle_t *handle, struct inode *inode,
* file system block.
*/
down_read(&EXT4_I(inode)->i_data_sem);
- if (ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS)) {
+ if (ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS))
retval = ext4_ext_map_blocks(handle, inode, map, 0);
- } else {
+ else
retval = ext4_ind_map_blocks(handle, inode, map, 0);
- }
+
if (retval > 0) {
unsigned int status;
--
2.39.5
next reply other threads:[~2024-10-14 14:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-14 14:06 Nicolas Bretz [this message]
2024-10-18 0:19 ` [PATCH v2] ext4: inode: Delete braces for single statements Theodore Ts'o
2024-10-18 0:50 ` Nicolas Bretz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241014140654.69613-1-bretznic@gmail.com \
--to=bretznic@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox