From: Greg KH <gregkh@linuxfoundation.org>
To: Mahmoud Adam <mngyadam@amazon.com>
Cc: jack@suse.cz, hch@lst.de, sashal@kernel.org, tytso@mit.edu,
linux-ext4@vger.kernel.org, regressions@lists.linux.dev
Subject: Re: [5.10.y] Regression in EXT3/4 with v5.10.227, LTP preadv03 is failing
Date: Mon, 21 Oct 2024 22:19:45 +0200 [thread overview]
Message-ID: <2024102122-sustained-camcorder-32fa@gregkh> (raw)
In-Reply-To: <lrkyqldyhpeb5.fsf@dev-dsk-mngyadam-1c-a2602c62.eu-west-1.amazon.com>
On Mon, Oct 21, 2024 at 07:15:58PM +0200, Mahmoud Adam wrote:
> Greg KH <gregkh@linuxfoundation.org> writes:
>
> > On Mon, Oct 21, 2024 at 05:43:54PM +0200, Mahmoud Adam wrote:
> >>
> >> Hello,
> >>
> >> In the latest 5.10.227 we see LTP preadv03 failing on EXT3/4, when
> >> bisected it was found that the commit dde4c1e1663b6 ("ext4: properly
> >> sync file size update after O_SYNC direct IO") is causing it
> >>
> >> This seems similar to what occurred before[1] and if I understand
> >> correctly it was because of missing dependency backport 936e114a245b6
> >> ("iomap: update ki_pos a little later in iomap_dio_complete") which was
> >> then backported to 5.15 & 6.1 but not to 5.10.
> >>
> >> *This is not failing on 5.15 nor 6.1, and it does fail consistently in x86-64 & ARM
> >>
> >> [1]: https://lore.kernel.org/all/20231205122122.dfhhoaswsfscuhc3@quack3/
> >>
> >
> >
> > What do you suggest be done?
> >
>
> I think as an urgent fix I would suggest reverting the mentioned commit
> and commits that depend on it from 5.10.y..
>
> 4911610c7a1fe ("ext4: fix warning in ext4_dio_write_end_io()")
> f8a7c342326f6 ("ext4: dax: fix overflowing extents beyond inode size when partially writing")
> dde4c1e1663b6 ("ext4: properly sync file size update after O_SYNC direct
> IO")
Great, can you submit a series of these reverted that you have tested to
fix the issue?
thanks,
greg k-h
next prev parent reply other threads:[~2024-10-21 20:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <lrkyqy12hpikl.fsf@dev-dsk-mngyadam-1c-a2602c62.eu-west-1.amazon.com>
2024-10-21 16:49 ` [5.10.y] Regression in EXT3/4 with v5.10.227, LTP preadv03 is failing Greg KH
2024-10-21 17:15 ` Mahmoud Adam
2024-10-21 20:19 ` Greg KH [this message]
2024-10-22 9:40 ` Jan Kara
2024-10-22 10:59 ` Mahmoud Adam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024102122-sustained-camcorder-32fa@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=mngyadam@amazon.com \
--cc=regressions@lists.linux.dev \
--cc=sashal@kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox