From: "Theodore Ts'o" <tytso@mit.edu>
To: Zhang Yi <yi.zhang@huawei.com>
Cc: "Darrick J. Wong" <djwong@kernel.org>,
Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] ext4: fix FS_IOC_GETFSMAP handling
Date: Sun, 27 Oct 2024 20:59:22 -0700 [thread overview]
Message-ID: <20241028035922.GC3842351@mit.edu> (raw)
In-Reply-To: <6bb74ccc-25e2-45c1-8a88-cfd093a194c7@huawei.com>
On Mon, Oct 28, 2024 at 09:47:46AM +0800, Zhang Yi wrote:
>
> IIRC, at the moment, fixed metadata does not appear in the middle of
> the block group.
The mke2fs from e2fsprogs will not create a file system like that
normally, no. *However* it is possible for fixed metadata to be in
the middle of the block group:
* If resize2fs does an off-line file system growth without a resize inode
or the reserved blocks in the resize inode has been exhausted
* If e2fsck needs to reallocate some fixed metadata blocks as part of
repairing a (very badly) corrupted file system.
* If there are blocks reported to mke2fs when the file system is created
* If a non-standard mkfs.ext4 is used by some other operating system which
reimplemented mke2fs for some reason (for example, because they wanted
to avoid using GPL'ed code).
So while these cases are quite uncommon, they *can* happen in the
wild, and we want GETFSMAP to be able to handle these file systems
correctly.
Cheers,
- Ted
next prev parent reply other threads:[~2024-10-28 3:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-23 13:59 [PATCH] ext4: fix FS_IOC_GETFSMAP handling Theodore Ts'o
2024-10-25 7:06 ` Zhang Yi
2024-10-25 15:42 ` Theodore Ts'o
2024-10-28 1:47 ` Zhang Yi
2024-10-28 3:59 ` Theodore Ts'o [this message]
2024-10-29 2:20 ` Zhang Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241028035922.GC3842351@mit.edu \
--to=tytso@mit.edu \
--cc=djwong@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).