From: Greg KH <gregkh@linuxfoundation.org>
To: Thorsten Blum <thorsten.blum@linux.dev>
Cc: Theodore Ts'o <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Kees Cook <kees@kernel.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Jan Kara <jack@suse.cz>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org
Subject: Re: [RESEND PATCH] ext4: Annotate struct fname with __counted_by()
Date: Tue, 5 Nov 2024 10:52:50 +0100 [thread overview]
Message-ID: <2024110530-ashen-deforest-9f71@gregkh> (raw)
In-Reply-To: <20241104234214.8094-2-thorsten.blum@linux.dev>
On Tue, Nov 05, 2024 at 12:42:14AM +0100, Thorsten Blum wrote:
> Add the __counted_by compiler attribute to the flexible array member
> name to improve access bounds-checking via CONFIG_UBSAN_BOUNDS and
> CONFIG_FORTIFY_SOURCE.
>
> Inline and use struct_size() to calculate the number of bytes to
> allocate for new_fn and remove the local variable len.
This is two different things, why not do this in two different patches?
thanks,
greg k-h
next prev parent reply other threads:[~2024-11-05 9:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-04 23:42 [RESEND PATCH] ext4: Annotate struct fname with __counted_by() Thorsten Blum
2024-11-05 9:52 ` Greg KH [this message]
2024-11-05 10:17 ` Thorsten Blum
-- strict thread matches above, loose matches on Subject: below --
2024-10-22 7:52 Thorsten Blum
2024-10-07 13:07 Thorsten Blum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024110530-ashen-deforest-9f71@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=adilger.kernel@dilger.ca \
--cc=gustavoars@kernel.org \
--cc=jack@suse.cz \
--cc=kees@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thorsten.blum@linux.dev \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).