Re: [PATCH v8 16/19] fsnotify: generate pre-content permission event on page fault

Randy Dunlap
2024-12-10T21:12:13Z

On 12/8/24 8:58 AM, Klara Modin wrote:
>> +/**
>> + * filemap_fsnotify_fault - maybe emit a pre-content event.
>> + * @vmf:    struct vm_fault containing details of the fault.
>> + * @folio:    the folio we're faulting in.
>> + *
>> + * If we have a pre-content watch on this file we will emit an event for this
>> + * range.  If we return anything the fault caller should return immediately, we
>> + * will return VM_FAULT_RETRY if we had to emit an event, which will trigger the
>> + * fault again and then the fault handler will run the second time through.
>> + *
>> + * This is meant to be called with the folio that we will be filling in to make
>> + * sure the event is emitted for the correct range.
>> + *
>> + * Return: a bitwise-OR of %VM_FAULT_ codes, 0 if nothing happened.
>> + */
>> +vm_fault_t filemap_fsnotify_fault(struct vm_fault *vmf)
>
> The parameters mentioned above do not seem to match with the function.

which causes a warning:

mm/filemap.c:3289: warning: Excess function parameter 'folio' description in 'filemap_fsnotify_fault'

--
~Randy