Re: Release candidate for e2fsprogs 1.47.2 is available

["Darrick J. Wong" <djwong@kernel.org>]

On Fri, Nov 29, 2024 at 08:34:29PM -0500, Theodore Ts'o wrote:
> Hi all,
> 
> There is a release candidate for e2fsprogs 1.47.2 available at:
> 
> https://www.kernel.org/pub/linux/kernel/people/tytso/e2fsprogs/testing/v1.47.2-rc1/e2fsprogs-1.47.2-rc1.tar.gz
> 
> It is also uploaded to Debian unstable, for folks who want to try that out.
> 
> A known issue is that f_clear_orphan_file is failing on s390x,
> powerpc, and ppc64 which is why Debian packages haven't been built on
> those architectures:
> 
>     https://buildd.debian.org/status/package.php?p=e2fsprogs

IOWs, the big endian architectures.

Hmmm, why does ext2fs_do_orphan_file_block_csum claim to return a __u32
yet the actual return statement returns an __le32:

	return ext2fs_cpu_to_le32(crc);

Particularly because ext2fs_orphan_file_block_csum_verify then compares
the returned __le32 value to a __u32 that was converted from the ondisk
structure:

	return ext2fs_le32_to_cpu(tail->ob_checksum) == crc;

AFAICT ext2fs_do_orphan_file_block_csum should not do that conversion,
and mkorphan_proc should be doing:

	tail->ob_checksum = cpu_to_le32(
			ext2fs_do_orphan_file_block_csum(...));

But I'm not that familiar with this code.

--D

> Please give it a try, and let me know if you run into any other
> problems.
> 
> Many thanks!!
> 
> 					- Ted
>