From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AFC0211294 for ; Thu, 6 Mar 2025 16:05:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=18.9.28.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741277104; cv=none; b=KULyHc5bq5BWMAL/vu+IKaSB7Fxo6dkL9obs2GnyiUjhKz2KHi7dtkahPUGYjHJ4KY1lgcIvp28K9IeUI9G4JSi4ouT10Tkl73XXf1oDuSTmIczBq3kOJDcZR5hAzbTBQjo+6/l5bTqe56pnam9NyoOw1CvKAXg90YSsHtzih9A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741277104; c=relaxed/simple; bh=cOoGxtcebT3u8VgggsX55aYM+nUJo9Wlfp8eesUGY+M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CnJx6SgeWAYOYereBomxqJYXjecRQgmh2SnFdr0D1E51dl6dWf9yhJipaIGpXn7ptCIs9aO8RinUgtuBjabLVcOhP0DuZDSlPW+NOCDKUoxmuxl0hIkv+wFbA0liyFWIDNUattSEYETw4z4NkuxMxl+WeVzikgVzdNI+pYjLVyI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mit.edu; spf=pass smtp.mailfrom=mit.edu; arc=none smtp.client-ip=18.9.28.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mit.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mit.edu Received: from trampoline.thunk.org (pool-173-48-112-92.bstnma.fios.verizon.net [173.48.112.92]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 526FxGlE006357 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 6 Mar 2025 10:59:16 -0500 Received: by trampoline.thunk.org (Postfix, from userid 15806) id 3D1372E010B; Thu, 06 Mar 2025 10:59:16 -0500 (EST) Date: Thu, 6 Mar 2025 10:59:16 -0500 From: "Theodore Ts'o" To: Ojaswin Mujoo Cc: linux-ext4@vger.kernel.org, Jan Kara , Ritesh Harjani , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Baokun Li , Jan Kara Subject: Re: [PATCH v2 2/2] ext4: protect ext4_release_dquot against freezing Message-ID: <20250306155916.GA279274@mit.edu> References: <20241121123855.645335-1-ojaswin@linux.ibm.com> <20241121123855.645335-3-ojaswin@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Mar 06, 2025 at 12:00:49PM +0530, Ojaswin Mujoo wrote: > On Thu, Nov 21, 2024 at 06:08:55PM +0530, Ojaswin Mujoo wrote: > > Protect ext4_release_dquot against freezing so that we > > don't try to start a transaction when FS is frozen, leading > > to warnings. > > > > Further, avoid taking the freeze protection if a transaction > > is already running so that we don't need end up in a deadlock > > as described in > > > > 46e294efc355 ext4: fix deadlock with fs freezing and EA inodes > > > > Suggested-by: Jan Kara > > Signed-off-by: Ojaswin Mujoo > > Hey Ted, > > Just a ping, I think you might have missed this patch. Let me know if > anything else is needed from my side. Yes, I did miss this patch; thanks for the reminder. It looks good and I've added it to my tree. - Ted