From: "Theodore Ts'o" <tytso@mit.edu>
To: Linus Torvalds <torvalds@linuxfoundation.org>
Cc: Jakub Acs <acsjakub@amazon.com>,
linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org,
Andreas Dilger <adilger.kernel@dilger.ca>,
Mahmoud Adam <mngyadam@amazon.com>,
stable@vger.kernel.org, security@kernel.org
Subject: Re: [PATCH] ext4: fix OOB read when checking dotdot dir
Date: Wed, 19 Mar 2025 12:46:02 -0400 [thread overview]
Message-ID: <20250319164602.GC1061595@mit.edu> (raw)
In-Reply-To: <CAHk-=wgzYVZ0ZNvcqC+yToX6nFx+SNZqTcyEvzm2RMP-TU-Dqw@mail.gmail.com>
On Wed, Mar 19, 2025 at 09:28:56AM -0700, Linus Torvalds wrote:
> Why would you use 'strcmp()' when you just checked that the length is one?
>
> IOW, if you are talking about "a bit more optimized", please just check
>
> de->name[0] == '.'
>
> after you've checked that the length is 1.
Yes, good point. My suggestion was to optimize htings by avoid
calling strcmp() in most cases, but you're absolutely correct that we
could do even better by *never* calling strcmp().
- Ted
prev parent reply other threads:[~2025-03-19 16:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-19 11:01 [PATCH] ext4: fix OOB read when checking dotdot dir Jakub Acs
2025-03-19 13:05 ` Theodore Ts'o
2025-03-19 16:28 ` Linus Torvalds
2025-03-19 16:46 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250319164602.GC1061595@mit.edu \
--to=tytso@mit.edu \
--cc=acsjakub@amazon.com \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mngyadam@amazon.com \
--cc=security@kernel.org \
--cc=stable@vger.kernel.org \
--cc=torvalds@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox