From: Arnd Bergmann <arnd@kernel.org>
To: "Theodore Ts'o" <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>
Cc: Arnd Bergmann <arnd@arndb.de>, Jan Kara <jack@suse.cz>,
Zhang Yi <yi.zhang@huawei.com>,
Ojaswin Mujoo <ojaswin@linux.ibm.com>,
"Darrick J. Wong" <djwong@kernel.org>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
"Ritesh Harjani (IBM)" <ritesh.list@gmail.com>,
Shida Zhang <zhangshida@kylinos.cn>,
Baokun Li <libaokun1@huawei.com>, Jann Horn <jannh@google.com>,
Brian Foster <bfoster@redhat.com>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] ext4: avoid -Wformat-security warning
Date: Wed, 23 Apr 2025 18:43:49 +0200 [thread overview]
Message-ID: <20250423164354.2780635-1-arnd@kernel.org> (raw)
From: Arnd Bergmann <arnd@arndb.de>
check_igot_inode() prints a variable string, which causes a harmless
warning with 'make W=1':
fs/ext4/inode.c:4763:45: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
4763 | ext4_error_inode(inode, function, line, 0, err_str);
Use a trivial "%s" format string instead.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
fs/ext4/inode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 94c7d2d828a6..3cfb1b670ea4 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -4760,7 +4760,7 @@ static int check_igot_inode(struct inode *inode, ext4_iget_flags flags,
return 0;
error:
- ext4_error_inode(inode, function, line, 0, err_str);
+ ext4_error_inode(inode, function, line, 0, "%s", err_str);
return -EFSCORRUPTED;
}
--
2.39.5
next reply other threads:[~2025-04-23 16:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-23 16:43 Arnd Bergmann [this message]
2025-04-24 11:39 ` [PATCH] ext4: avoid -Wformat-security warning Jan Kara
2025-04-24 12:31 ` Arnd Bergmann
2025-04-24 13:48 ` Jan Kara
2025-05-20 14:40 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250423164354.2780635-1-arnd@kernel.org \
--to=arnd@kernel.org \
--cc=adilger.kernel@dilger.ca \
--cc=arnd@arndb.de \
--cc=bfoster@redhat.com \
--cc=djwong@kernel.org \
--cc=jack@suse.cz \
--cc=jannh@google.com \
--cc=libaokun1@huawei.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ojaswin@linux.ibm.com \
--cc=ritesh.list@gmail.com \
--cc=tytso@mit.edu \
--cc=willy@infradead.org \
--cc=yi.zhang@huawei.com \
--cc=zhangshida@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox