From: "Theodore Ts'o" <tytso@mit.edu>
To: Hans Holmberg <Hans.Holmberg@wdc.com>
Cc: "fstests@vger.kernel.org" <fstests@vger.kernel.org>,
"zlang@kernel.org" <zlang@kernel.org>,
"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
Carlos Maiolino <cem@kernel.org>,
"djwong@kernel.org" <djwong@kernel.org>, hch <hch@lst.de>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
"adilger.kernel@dilger.ca" <adilger.kernel@dilger.ca>
Subject: Re: [PATCH] ext4/002: make generic to support xfs
Date: Fri, 2 May 2025 09:33:09 -0400 [thread overview]
Message-ID: <20250502133309.GB29583@mit.edu> (raw)
In-Reply-To: <20250502113415.14882-1-hans.holmberg@wdc.com>
On Fri, May 02, 2025 at 11:35:01AM +0000, Hans Holmberg wrote:
> xfs supports separate log devices and as this test now passes, share
> it by turning it into a generic test.
Was this fixed by a kernel commit to the XFS tree? If so, could you
add a _fixed_by_kernel_commit pointing at the fix? And while you're
at it, could you add:
[ $FSTYP == "ext4" ] && \
_fixed_by_kernel_commit 273108fa5015 \
"ext4: handle read only external journal device"
to the test? This will make it easier for people using LTS kernels to
know which commits they need to backport.
Many thanks!
- Ted
next prev parent reply other threads:[~2025-05-02 13:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-02 11:35 [PATCH] ext4/002: make generic to support xfs Hans Holmberg
2025-05-02 13:33 ` Theodore Ts'o [this message]
2025-05-05 9:20 ` Hans Holmberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250502133309.GB29583@mit.edu \
--to=tytso@mit.edu \
--cc=Hans.Holmberg@wdc.com \
--cc=adilger.kernel@dilger.ca \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=hch@lst.de \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox