[PATCH] ext4/002: make generic to support xfs

[PATCH] ext4/002: make generic to support xfs

[Hans Holmberg]

xfs supports separate log devices and as this test now passes, share
it by turning it into a generic test.

This should not result in a new failure for other file systems as only
ext2/ext3/ext4 and xfs support mkfs with SCRATCH_LOGDEVs.

Signed-off-by: Hans Holmberg <hans.holmberg@wdc.com>
---
 tests/{ext4/002 => generic/766}         | 3 ++-
 tests/{ext4/002.out => generic/766.out} | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)
 rename tests/{ext4/002 => generic/766} (98%)
 rename tests/{ext4/002.out => generic/766.out} (98%)

diff --git a/tests/ext4/002 b/tests/generic/766
similarity index 98%
rename from tests/ext4/002
rename to tests/generic/766
index 6c1e1d926973..dbdb8e9266c0 100755
--- a/tests/ext4/002
+++ b/tests/generic/766
@@ -3,10 +3,11 @@
 # Copyright (c) 2009 Christoph Hellwig.
 # Copyright (c) 2020 Lukas Czerner.
 #
-# FS QA Test No. 002
+# FS QA Test No. 766
 #
 # Copied from tests generic/050 and adjusted to support testing
 # read-only external journal device on ext4.
+# Moved to generic from ext4/002 to support xfs as well
 #
 # Check out various mount/remount/unmount scenarious on a read-only
 # logdev blockdev.
diff --git a/tests/ext4/002.out b/tests/generic/766.out
similarity index 98%
rename from tests/ext4/002.out
rename to tests/generic/766.out
index 579bc7e0cd78..975751751749 100644
--- a/tests/ext4/002.out
+++ b/tests/generic/766.out
@@ -1,4 +1,4 @@
-QA output created by 002
+QA output created by 766
 setting log device read-only
 mounting with read-only log device:
 mount: device write-protected, mounting read-only
-- 
2.34.1

Re: [PATCH] ext4/002: make generic to support xfs

[Theodore Ts'o]

On Fri, May 02, 2025 at 11:35:01AM +0000, Hans Holmberg wrote:
> xfs supports separate log devices and as this test now passes, share
> it by turning it into a generic test.

Was this fixed by a kernel commit to the XFS tree?  If so, could you
add a _fixed_by_kernel_commit pointing at the fix?  And while you're
at it, could you add:


[ $FSTYP == "ext4" ] && \
	_fixed_by_kernel_commit 273108fa5015 \
	"ext4: handle read only external journal device"

to the test?  This will make it easier for people using LTS kernels to
know which commits they need to backport.

Many thanks!

						- Ted

Re: [PATCH] ext4/002: make generic to support xfs

[Hans Holmberg]

On 02/05/2025 15:33, Theodore Ts'o wrote:
> On Fri, May 02, 2025 at 11:35:01AM +0000, Hans Holmberg wrote:
>> xfs supports separate log devices and as this test now passes, share
>> it by turning it into a generic test.
> 
> Was this fixed by a kernel commit to the XFS tree?  If so, could you
> add a _fixed_by_kernel_commit pointing at the fix?  And while you're
> at it, could you add:
> 
> 
> [ $FSTYP == "ext4" ] && \
> 	_fixed_by_kernel_commit 273108fa5015 \
> 	"ext4: handle read only external journal device"
> 
> to the test?  This will make it easier for people using LTS kernels to
> know which commits they need to backport.
> 
> Many thanks!
> 
> 						- Ted

The patch has been picked up in xfs for-next branch but it's not in
linus tree yet, so no stable commit hash for that yet.

I can add it in a v2, along with the ext4 fixed-commit once the xfsfix
is merged upstream.

Thanks!