public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: Nicolas Bretz <bretznic@gmail.com>
Cc: linux-ext4@vger.kernel.org, tytso@mit.edu, jack@suse.cz,
	adilger.kernel@dilger.ca
Subject: Re: [PATCH] ext4: added missing kfree
Date: Fri, 2 May 2025 13:37:42 -0700	[thread overview]
Message-ID: <20250502203742.GF25655@frogsfrogsfrogs> (raw)
In-Reply-To: <20250502174012.18597-1-bretznic@gmail.com>

On Fri, May 02, 2025 at 10:40:12AM -0700, Nicolas Bretz wrote:
> Added one missing kfree to fsmap.c
> 
> Signed-off-by: Nicolas Bretz <bretznic@gmail.com>
> ---
>  fs/ext4/fsmap.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/ext4/fsmap.c b/fs/ext4/fsmap.c
> index b232c2767534..d41210abea0c 100644
> --- a/fs/ext4/fsmap.c
> +++ b/fs/ext4/fsmap.c
> @@ -304,6 +304,7 @@ static inline int ext4_getfsmap_fill(struct list_head *meta_list,
>  	fsm->fmr_length = len;
>  	list_add_tail(&fsm->fmr_list, meta_list);
>  
> +	kfree(fsm);

OI: UAF, NAK.

--D

>  	return 0;
>  }
>  
> -- 
> 2.43.0
> 
> 

  reply	other threads:[~2025-05-02 20:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-02 17:40 [PATCH] ext4: added missing kfree Nicolas Bretz
2025-05-02 20:37 ` Darrick J. Wong [this message]
2025-05-02 22:26   ` Nicolas Bretz
2025-05-03 16:45     ` Theodore Ts'o
2025-05-04  0:48       ` Nicolas Bretz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250502203742.GF25655@frogsfrogsfrogs \
    --to=djwong@kernel.org \
    --cc=adilger.kernel@dilger.ca \
    --cc=bretznic@gmail.com \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox