Re: [PATCH v11 02/16] xfs: only call xfs_setsize_buftarg once per buffer target

John Garry
2025-05-06T06:58:23Z

On 06/05/2025 05:22, Christoph Hellwig wrote:
>>> It seems simpler to just have the individual sync_blockdev() calls from
>>> xfs_alloc_buftarg(), rather than adding ERR_PTR() et al handling in both
>>> xfs_alloc_buftarg() and xfs_open_devices().
>> Which of the following is better:
> To me version 2 looks much better. I had initial reservations as
> ERR_PTR doesn't play well with userspace, but none of this code is
> in libxfs, so that should be fine.

cool, that is what we/I had gone with in prep'ing v12