Linux EXT4 FS development
 help / color / mirror / Atom feed
From: libaokun@huaweicloud.com
To: linux-ext4@vger.kernel.org
Cc: tytso@mit.edu, adilger.kernel@dilger.ca, jack@suse.cz,
	linux-kernel@vger.kernel.org, yi.zhang@huawei.com,
	yangerkun@huawei.com, libaokun1@huawei.com,
	libaokun@huaweicloud.com
Subject: [PATCH 3/4] ext4: get rid of some obsolete EXT4_MB_HINT flags
Date: Fri, 23 May 2025 16:58:20 +0800	[thread overview]
Message-ID: <20250523085821.1329392-4-libaokun@huaweicloud.com> (raw)
In-Reply-To: <20250523085821.1329392-1-libaokun@huaweicloud.com>

From: Baokun Li <libaokun1@huawei.com>

Since nobody has used these EXT4_MB_HINT flags for ages,
let's remove them.

Signed-off-by: Baokun Li <libaokun1@huawei.com>
---
 fs/ext4/ext4.h              | 6 ------
 include/trace/events/ext4.h | 3 ---
 2 files changed, 9 deletions(-)

diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
index 16c14dd09df6..f6d01702423d 100644
--- a/fs/ext4/ext4.h
+++ b/fs/ext4/ext4.h
@@ -185,14 +185,8 @@ enum criteria {
 
 /* prefer goal again. length */
 #define EXT4_MB_HINT_MERGE		0x0001
-/* blocks already reserved */
-#define EXT4_MB_HINT_RESERVED		0x0002
-/* metadata is being allocated */
-#define EXT4_MB_HINT_METADATA		0x0004
 /* first blocks in the file */
 #define EXT4_MB_HINT_FIRST		0x0008
-/* search for the best chunk */
-#define EXT4_MB_HINT_BEST		0x0010
 /* data is being allocated */
 #define EXT4_MB_HINT_DATA		0x0020
 /* don't preallocate (for tails) */
diff --git a/include/trace/events/ext4.h b/include/trace/events/ext4.h
index 156908641e68..33b204165cc0 100644
--- a/include/trace/events/ext4.h
+++ b/include/trace/events/ext4.h
@@ -23,10 +23,7 @@ struct partial_cluster;
 
 #define show_mballoc_flags(flags) __print_flags(flags, "|",	\
 	{ EXT4_MB_HINT_MERGE,		"HINT_MERGE" },		\
-	{ EXT4_MB_HINT_RESERVED,	"HINT_RESV" },		\
-	{ EXT4_MB_HINT_METADATA,	"HINT_MDATA" },		\
 	{ EXT4_MB_HINT_FIRST,		"HINT_FIRST" },		\
-	{ EXT4_MB_HINT_BEST,		"HINT_BEST" },		\
 	{ EXT4_MB_HINT_DATA,		"HINT_DATA" },		\
 	{ EXT4_MB_HINT_NOPREALLOC,	"HINT_NOPREALLOC" },	\
 	{ EXT4_MB_HINT_GROUP_ALLOC,	"HINT_GRP_ALLOC" },	\
-- 
2.46.1


  parent reply	other threads:[~2025-05-23  9:03 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-23  8:58 [PATCH 0/4] ext4: better scalability for ext4 block allocation libaokun
2025-05-23  8:58 ` [PATCH 1/4] ext4: add ext4_try_lock_group() to skip busy groups libaokun
2025-05-28 15:05   ` Ojaswin Mujoo
2025-05-30  8:20     ` Baokun Li
2025-06-10 12:07       ` Ojaswin Mujoo
2025-05-23  8:58 ` [PATCH 2/4] ext4: move mb_last_[group|start] to ext4_inode_info libaokun
2025-05-29 12:56   ` Jan Kara
2025-05-30  9:31     ` Baokun Li
2025-06-02 15:44       ` Jan Kara
2025-06-04  8:13         ` Baokun Li
2025-05-23  8:58 ` libaokun [this message]
2025-05-28 15:10   ` [PATCH 3/4] ext4: get rid of some obsolete EXT4_MB_HINT flags Ojaswin Mujoo
2025-05-29 12:57   ` Jan Kara
2025-05-23  8:58 ` [PATCH 4/4] ext4: fix typo in CR_GOAL_LEN_SLOW comment libaokun
2025-05-28 15:11   ` Ojaswin Mujoo
2025-05-29 12:57   ` Jan Kara
2025-05-28 14:53 ` [PATCH 0/4] ext4: better scalability for ext4 block allocation Ojaswin Mujoo
2025-05-29 12:24   ` Baokun Li
2025-06-10 12:06     ` Ojaswin Mujoo
2025-06-10 13:48       ` Baokun Li
2025-06-11  8:22         ` Ojaswin Mujoo
2025-06-12 11:30           ` Baokun Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250523085821.1329392-4-libaokun@huaweicloud.com \
    --to=libaokun@huaweicloud.com \
    --cc=adilger.kernel@dilger.ca \
    --cc=jack@suse.cz \
    --cc=libaokun1@huawei.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tytso@mit.edu \
    --cc=yangerkun@huawei.com \
    --cc=yi.zhang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox