Re: [PATCH 06/10] fs/xfs: transition from deprecated .mmap hook to .mmap_prepare

Christian Brauner
2025-06-17T11:46:03Z

On Mon, Jun 16, 2025 at 10:08:03PM -0700, Christoph Hellwig wrote:
> On Mon, Jun 16, 2025 at 08:33:25PM +0100, Lorenzo Stoakes wrote:
> > STATIC int
> > -xfs_file_mmap(
> > - struct file *file,
> > - struct vm_area_struct *vma)
> > +xfs_file_mmap_prepare(
> > + struct vm_area_desc *desc)
>
> Please stick to the existing alignment for the declarations.
>
> Otherwise this looks good.

Fixed in-tree.