Re: [PATCH v3 08/13] generic/1229: Stress fsx with atomic writes enabled

Darrick J. Wong
2025-07-23T14:56:45Z

On Wed, Jul 23, 2025 at 12:00:48PM +0530, Ojaswin Mujoo wrote:
> On Thu, Jul 17, 2025 at 09:22:30AM -0700, Darrick J. Wong wrote:
> > On Sat, Jul 12, 2025 at 07:42:50PM +0530, Ojaswin Mujoo wrote:
> > > Stress file with atomic writes to ensure we excercise codepaths
> > > where we are mixing different FS operations with atomic writes
> > >
> > > Suggested-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
> > > Signed-off-by: Ojaswin Mujoo <ojaswin@linux.ibm.com>
> >
> > Hrm, doesn't generic/521 test this already if the fs happens to support
> > atomic writes?
> >
> > --D
>
> Hi Darrick,
>
> Yes but I wanted one with _require_scratch_write_atomic and writes going
> to SCRATCH fs to explicitly test atomic writes as that can get missed in
> g/521.
>
> Would you instead prefer to have those changes in g/521?

Oh, I see. You're setting the opsize to awu_max so that you're
guaranteed to get maximally sized atomic writes, which might not happen
with regular g521.

Ok I'm convinced,
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> Regards,
> Ojaswin
>