From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9BAF6F305 for ; Wed, 24 Sep 2025 01:21:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758676910; cv=none; b=NLjRgDviBK0MHFevBEnHznjvjNS/xgKBwlcj2WPZziN6/k44f7j+mjFkOxA4QwiM4aNtwc0C0UTfcZgbA1DC5Jp9Rqlil/n082WIb2+2Ey1S6oRLEGIe8TEjNPW40LTXwWU9zpjHldidf+Cr5gPQ8xOvswN94cMK5f51knNc/Eg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758676910; c=relaxed/simple; bh=bjvA8fGI7JwRYl6g5GmNHPGgmo0MORD6QycaS7qPMk8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=O3VoSbU3PFSGOozDz7BM1EhOedwH+grhg2hKq6qoZjeaL+SYf+QpuldwntPp4OAjgdwU171eIfXYRBvblI8F+4Az/BjLSVq3FAuLRLG5BqfyFpQ9q8Qiqo/MR13dHxlMRZWqZhkVeUgXF8Tv0Hrh+kHmJeQCSE6C6EISR3eKoK8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bhsrL4Jz; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bhsrL4Jz" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-26f0c5455e2so30106675ad.3 for ; Tue, 23 Sep 2025 18:21:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1758676908; x=1759281708; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=sO5HRgNy0x9UUMS9KISqgLEyBw2+6jY6BB1GoUPd7WU=; b=bhsrL4JzwU1Q9Orj8zgk1312iA2VTb4/95dKWJfnb+IB23X73r3eT+R9Rnv58Kk2Sb O87pi6SVZ7pyUEmIum2xd7XEUmnRt2W3zTiMNBx0NQAfuHmGiHBfkOJLq61wkSWXwg+8 2O3nqoLePr99bR8TRM982ydY/Tt08HoRp7Ef9xjvTc80K9VZw7zSj8KEUc7SpFMkqH8K 9aU9wjxmb/XHadHb7Kt6b0DKJOe0ygT2iGIzklsIlPfF6l1GY4AqCnC2D5Nri99b9PXi d8hIz0DhzbfGwX1QnWg2645JtWvo5C2cue0W56FGc17IO12alKM3y1IhpSHI4c94gIIN 9M1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758676908; x=1759281708; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sO5HRgNy0x9UUMS9KISqgLEyBw2+6jY6BB1GoUPd7WU=; b=b4NZOtctmRza7Hgjsom/rTJEZ50wmz4iM/nOB4cAAV8zs76QlnHQs59N9pTXJRbSrA IoizQXhFtrI/B6Is6TsthHgWdXxNZwE2Nn4g3v2UPcY9dFvScReT9NE2agRTL+YrKdxr +lXj3fkt1/yH6x+EPkHvs7P6S/grrf8BdUFDPT2uDFRHYxuD1oDHc2htQu09UuIBEkvn PAOTDZKK94NCPrXNx852fJQaxaoDfEBHZLi3rKsstxse0N/0pgO9ipBkZzmYoUiuo63x iVyCPP546XVo1rE7/DWKRUSKE0dZCMp3mmu8FrFULqvpvA+2rOAgxTI25LLjcnbqZwU3 bTZQ== X-Forwarded-Encrypted: i=1; AJvYcCUnzDFPERKHRlcWL3wMq2bTJAPp/IZOJ051AHiX6Lgj1S46G7YiI1GJoNYaQTD79MipmcwOJSYsAK0H@vger.kernel.org X-Gm-Message-State: AOJu0YyYZcp9QewjFRuA/xLEI0FI011y+KsprctffYfJO6+/XWdXP6+r Rc2vKIJVd4dI3y51vD0o52IzI10W/VPIxGgrx6MLYzeqiZQ6dctL/amt X-Gm-Gg: ASbGncsMZingqD4BDHagf6L2mBs4vY7y1MM7oL6C9yXOWEIn5DKkJbWzG9cILC5FWqj PIK5TADGjlVKNQ7vwzLZdYmZkQNrkq5M9yHkB/sfQFgNiH8HfM1PETkH9V/ulrXmMqeRvmwWVVW htNSRC59p4nLTGdCkyalakZR2qBB6TTq7yWnAIe/UFWcGG91FotYjDKcAh2rNDIMBuv4JWb4MUt tuzyxbnJ8F5/OWIWqpXJ0ErHs0ygEFUvbsx2LP5j9I2OZNn6QMfMN/0qTe03tLe3/FqUbr5MM40 TFjszoR5SdyTTvnTS/4+saphoqN7ehFy7DGlvl2p6glNSmixzDcpV4afqHJPw5wFlm4+ZEKvsu3 pAtLLIQJTHEGDC/YxSvEdB2KMsFTRjx6OJi2vWo4W7l+QawPIzqYC437e5FihZVmylQnnwT4gy8 BJLw== X-Google-Smtp-Source: AGHT+IGnZhuY/0g8lnXz+Z/YLAJosROMUYlrw7/UXNLQAe97Gu6XpKqxgllMke/LklTZYR9SHyju6Q== X-Received: by 2002:a17:903:288:b0:24c:784c:4a90 with SMTP id d9443c01a7336-27cc0fa8735mr62779735ad.1.1758676907949; Tue, 23 Sep 2025 18:21:47 -0700 (PDT) Received: from deepanshu-kernel-hacker.. ([2405:201:682f:3094:a860:817b:dcc:3e4a]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2698016da85sm172933315ad.50.2025.09.23.18.21.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Sep 2025 18:21:47 -0700 (PDT) From: Deepanshu Kartikey To: adilger.kernel@dilger.ca Cc: tytso@mit.edu, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] ext4: validate ea_ino and size in check_xattrs Date: Wed, 24 Sep 2025 06:51:42 +0530 Message-ID: <20250924012142.1096152-1-kartikey406@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Thank you for the feedback on the e2fsck coordination. You raise a valid point about the complete repair workflow. I'm happy to work on a corresponding e2fsck patch if that would be helpful, though I'd appreciate guidance on the preferred approach: 1. Should I proceed with the kernel patch first and then work on e2fsck, or would you prefer coordinated patches? 2. For the e2fsck side, would the appropriate fix be to: - Clear e_value_inum when e_value_size is zero, or - Remove the entire corrupted xattr entry? I'm new to e2fsprogs development but willing to learn the codebase if you think it's valuable to have matching fixes. Alternatively, if there are others typically handling the e2fsck side of ext4 corruption fixes, I'm happy to focus on the kernel patch and coordinate with them. Thanks for considering the broader user experience - I hadn't fully thought through the repair workflow. Deepanshu Kartikey