From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Theodore Ts'o <tytso@mit.edu>,
zlang@redhat.com, fstests@vger.kernel.org,
linux-xfs@vger.kernel.org,
linux-ext4 <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH 6/8] common/filter: fix _filter_file_attributes to handle xfs file flags
Date: Tue, 21 Oct 2025 07:47:50 -0700 [thread overview]
Message-ID: <20251021144750.GG3356773@frogsfrogsfrogs> (raw)
In-Reply-To: <aPcadbSFFBj4Do4c@infradead.org>
On Mon, Oct 20, 2025 at 10:30:29PM -0700, Christoph Hellwig wrote:
> On Mon, Oct 20, 2025 at 09:37:13AM -0700, Darrick J. Wong wrote:
> > [add tytso and linux-ext4]
> >
> > I think we should standardize on the VFS (aka file_getattr) flag values,
> > which means the xfs version more or less wins.
>
> Ok, I'm more than confused than before. Shouldn't we simply use
> separate filters for FS_IOC_GETFLAGS vs FS_IOC_FSGETXATTR?
Yeah. I was going to just provide both versions, but then I went down
the rabbithole of navelgazing about "Is upstream going to accept a
helper for the ext4 lsattr flags even though there are no users?" and
then wandered off to tackle actual useful things like mount/unmount
races in fuse. :P
--D
prev parent reply other threads:[~2025-10-21 14:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <176054617853.2391029.10911105763476647916.stgit@frogsfrogsfrogs>
[not found] ` <176054618007.2391029.16547003793604851342.stgit@frogsfrogsfrogs>
[not found] ` <aPHE0N8JX4H8eEo6@infradead.org>
[not found] ` <20251017162218.GD6178@frogsfrogsfrogs>
[not found] ` <aPXeQW0ISn6_aCoP@infradead.org>
2025-10-20 16:37 ` [PATCH 6/8] common/filter: fix _filter_file_attributes to handle xfs file flags Darrick J. Wong
2025-10-21 5:30 ` Christoph Hellwig
2025-10-21 14:47 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251021144750.GG3356773@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=hch@infradead.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox