Re: [PATCH 1/2] ext4: fix up copying of mount_opts in superblock tuning ioctls

Fedor Pchelkin
2025-10-29T09:47:32Z

On Wed, 29. Oct 17:22, kernel test robot wrote:
> All errors (new ones prefixed by >>):
>
> In file included from <command-line>:
> >> ./usr/include/linux/ext4.h:141:30: error: expected ':', ',', ';', '}' or '__attribute__' before '__nonstring'
> 141 | __u8 mount_opts[64] __nonstring;
> | ^~~~~~~~~~~

That's my fault, apologies. HDRTEST was not in my build testing for
these patches due to mistake.

There should be '__kernel_nonstring', not '__nonstring'. The whole
annotation part is questionable though, maybe you think it's not needed at
all here?

Before sending out v2, I'll wait for the feedback on patch 2/2 - whether
the commit 8ecb790ea8c3 ("ext4: avoid potential buffer over-read in
parse_apply_sb_mount_options()") should be reverted or fixed with extra
memtostr() stuff like that patch proposes..?

Thanks!