public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: Christian Brauner <brauner@kernel.org>
To: Mateusz Guzik <mjguzik@gmail.com>
Cc: linux-fsdevel@vger.kernel.org,
	 Alexander Viro <viro@zeniv.linux.org.uk>,
	Jan Kara <jack@suse.cz>,
	linux-btrfs@vger.kernel.org,  linux-ext4@vger.kernel.org,
	linux-xfs@vger.kernel.org
Subject: Re: [PATCH RFC 4/8] btrfs: use super write guard in sb_start_write()
Date: Tue, 4 Nov 2025 21:56:00 +0100	[thread overview]
Message-ID: <20251104-abgearbeitet-rotwild-09b3c0375625@brauner> (raw)
In-Reply-To: <cxrp3a7wu5lz5o6fiwleqiqwqm6xyevdjiega77mwxy5aekeab@522tt37vnwip>

On Tue, Nov 04, 2025 at 06:00:29PM +0100, Mateusz Guzik wrote:
> On Tue, Nov 04, 2025 at 01:12:33PM +0100, Christian Brauner wrote:
> > Signed-off-by: Christian Brauner <brauner@kernel.org>
> > ---
> >  fs/btrfs/volumes.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
> > index 2bec544d8ba3..4152b0a5537a 100644
> > --- a/fs/btrfs/volumes.c
> > +++ b/fs/btrfs/volumes.c
> > @@ -4660,7 +4660,8 @@ static int balance_kthread(void *data)
> >  	struct btrfs_fs_info *fs_info = data;
> >  	int ret = 0;
> >  
> > -	sb_start_write(fs_info->sb);
> > +	guard(super_write)(fs_info->sb);
> > +
> >  	mutex_lock(&fs_info->balance_mutex);
> >  	if (fs_info->balance_ctl)
> >  		ret = btrfs_balance(fs_info, fs_info->balance_ctl, NULL);
> > 
> 
> this missed sb_end_write call removal

Thanks, fixed!

  reply	other threads:[~2025-11-04 20:56 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-04 12:12 [PATCH RFC 0/8] fs: introduce super write guard Christian Brauner
2025-11-04 12:12 ` [PATCH RFC 1/8] fs: add super_write_guard Christian Brauner
2025-11-04 12:32   ` Jan Kara
2025-11-04 12:12 ` [PATCH RFC 2/8] btrfs: use super write guard in btrfs_reclaim_bgs_work() Christian Brauner
2025-11-04 20:42   ` Qu Wenruo
2025-11-05 16:33     ` Daniel Vacek
2025-11-04 12:12 ` [PATCH RFC 3/8] btrfs: use super write guard btrfs_run_defrag_inode() Christian Brauner
2025-11-05 16:38   ` Daniel Vacek
2025-11-06  8:19   ` David Sterba
2025-11-04 12:12 ` [PATCH RFC 4/8] btrfs: use super write guard in sb_start_write() Christian Brauner
2025-11-04 17:00   ` Mateusz Guzik
2025-11-04 20:56     ` Christian Brauner [this message]
2025-11-04 12:12 ` [PATCH RFC 5/8] ext4: use super write guard in write_mmp_block() Christian Brauner
2025-11-04 12:32   ` Jan Kara
2025-11-04 13:06   ` Theodore Ts'o
2025-11-05 18:33   ` Daniel Vacek
2025-11-06  9:24     ` Jan Kara
2025-11-06 10:04       ` Daniel Vacek
2025-11-04 12:12 ` [PATCH RFC 6/8] btrfs: use super write guard in relocating_repair_kthread() Christian Brauner
2025-11-04 12:12 ` [PATCH RFC 7/8] open: use super write guard in do_ftruncate() Christian Brauner
2025-11-04 12:32   ` Jan Kara
2025-11-05 18:37   ` Daniel Vacek
2025-11-04 12:12 ` [PATCH RFC 8/8] xfs: use super write guard in xfs_file_ioctl() Christian Brauner
2025-11-04 17:08   ` Darrick J. Wong
2025-11-04 20:57     ` Christian Brauner
2025-11-05 17:47       ` Darrick J. Wong
2025-11-05 18:40   ` Daniel Vacek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251104-abgearbeitet-rotwild-09b3c0375625@brauner \
    --to=brauner@kernel.org \
    --cc=jack@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=mjguzik@gmail.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox