Re: [PATCH RFC 4/8] btrfs: use super write guard in sb_start_write()

Mateusz Guzik
2025-11-04T17:00:45Z

On Tue, Nov 04, 2025 at 01:12:33PM +0100, Christian Brauner wrote:
> Signed-off-by: Christian Brauner <brauner@kernel.org>
> ---
> fs/btrfs/volumes.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
> index 2bec544d8ba3..4152b0a5537a 100644
> --- a/fs/btrfs/volumes.c
> +++ b/fs/btrfs/volumes.c
> @@ -4660,7 +4660,8 @@ static int balance_kthread(void *data)
> struct btrfs_fs_info *fs_info = data;
> int ret = 0;
>
> - sb_start_write(fs_info->sb);
> + guard(super_write)(fs_info->sb);
> +
> mutex_lock(&fs_info->balance_mutex);
> if (fs_info->balance_ctl)
> ret = btrfs_balance(fs_info, fs_info->balance_ctl, NULL);
>

this missed sb_end_write call removal