Re: [PATCH v2 24/24] ext4: enable block size larger than page size

["Theodore Ts'o" <tytso@mit.edu>]

On Mon, Nov 10, 2025 at 01:51:28PM +0100, Pankaj Raghav wrote:
> 
> Are you adding the experimental flag because allocation failures can occur with
> LBS configuration or because it is a new feature (or both)?

I'm going to guess that it was added to mirror what XFS did.

I'll note that this is generally not the pattern for ext4, where we
tend to put these warnings in mke2fs/mkfs.ext4, and by not enabling
them by default.  We haven't historically put them as a warning printk
because I don't believe most users read dmesg output.  :-)

When we've wanted to put some kind of warning or disclaimer in the
kernel, my bias has been to add some kind of Kconfig feature flag,
say, "CONFIG_FS_LARGE_BLOCKSIZE" or "CONFIG_EXT4_LARGE_BLOCKSIZE"
which can either have a warning of its experimental nature in the
config descrption, or if it's *reallY* on the edge (not in this case,
in my opinion) by putting an explicit dependency on
CONFIG_EXPERIMENTAL.

I will admit that most users don't read the Kconfig help text, since
most uesrs aren't even compiling their own kernels :-), but it does
allow for more description of why it might be considered
"experimental" for distribution engineers, and it's less disruptive
when we inevitably forget to remove the experimental warning.  :-)

That being said, this is a personal preference sort of thing, and
people of good will can disagree about what's the best way to approach
this sort of warning.

Cheers,

						- Ted

P.S.  I'm happy not having any kind of experimental warning for bs >
ps, since users would have to affirmatively request a 64k blocksize in
mkfs, and most users don't override the default when creating file
systems, so I assume that people who do so Know What They Are Doing.