Re: [PATCH 1/4] fs: send uevents for filesystem mount events

["Darrick J. Wong" <djwong@kernel.org>]

On Wed, Dec 17, 2025 at 09:26:41PM -0800, Christoph Hellwig wrote:
> > +#define ADVANCE_ENV(envp, buf, buflen, written) \
> > +	do { \
> > +		ssize_t __written = (written); \
> > +\
> > +		WARN_ON((buflen) < (__written) + 1); \
> > +		*(envp) = (buf); \
> > +		(envp)++; \
> > +		(buf) += (__written) + 1; \
> > +		(buflen) -= (__written) + 1; \
> > +	} while (0)
> 
> Any reason this is a macro vs an (inline?) function?  Looking at this a
> bit more, could this simply use a seq_buf?

I'll change it to something like this:

	seq_buf_init(&sbuf, buf, buflen);
	envp = env;

	/*
	 * Add a second null terminator on the end so the next printf can start
	 * printing at the second null terminator.
	 */
	seq_buf_get_buf(&sbuf, envp++);
	seq_buf_printf(&sbuf, "TYPE=filesystem");
	seq_buf_putc(&sbuf, 0);

	seq_buf_get_buf(&sbuf, envp++);
	seq_buf_printf(&sbuf, "SID=%s", sb->s_id);
	seq_buf_putc(&sbuf, 0);

	...

	/* Add null terminator to strings array */
	*envp = NULL;

That does look a lot cleaner than opencoding it.

--D