From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 132A230FC12 for ; Tue, 13 Jan 2026 19:24:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768332277; cv=none; b=qqUrhSfy0M3cANh2HZKUvZKDo0TF8IyFYGq4NFM08XnJjCtYE4IoOjWlkDx52qI8+pWqtKyxaGxp631wR5aKeXV/s1J3P+OZh4PBpBzA8YacbAREBOAIucmxRclzNGyYfNuDIE3a7RxJTU67IWsftRIlQhPUNEqOKfrUuwuTNpM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768332277; c=relaxed/simple; bh=w4v+BwX2tgJ0XT3Ynx3Ta5J3Yw7ZRDmO9U5J2is2t7Y=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=WrlBNguVXjmOTuGPZE1UJSIkpL8wlRvoCs8P78Ae0pOkgeHINAwa8mYeYSjeCyucnN/cE6Bf91TXg/b9EljLQFo0NkZ0kfr+jd/B9rmvwcvkIBf0qN1amnn1uV8Uz40bJM+tfV6syllg4uphvQaFzzC3JxllTcXm1eQL94MsTHs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UD9JtAPt; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UD9JtAPt" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-42fb0fc5aa9so3763619f8f.1 for ; Tue, 13 Jan 2026 11:24:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768332274; x=1768937074; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=9OiWidXDlc9SIxtf//Pc3bF1d2VDX0rCMR5B+TBktRE=; b=UD9JtAPtaIQm/J+3ZFhViueHB/WkjJU+YJsPKl6LHs7ja5erVP0en3pohY/ZVgQG/k eyWzj0M4HS4eiNhM7VLUgP+2uB+UdmJaGTJZzKSS/rxnnrwP80tkeEpktGGkDx7VH2Jk iNO4yCQ5Yn3aBqqmR6e4LoCdrCNoXgBS1PKZ8X20iSHKJyrq1Bb7ZNmWggVgKmsIEt2+ bYIt4VtzOToFtAhDMx4YKc1Ibrl0mbkb5i8V72wn2dFBuGw6zDBgthUb341aDs//Xq9y BbaZHBo7dwLkWVwapSpVkkn58M7L+bRf4hstNjG9jR2K+7KQ0/e4tNj9t7C4uCCoApde 1rzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768332274; x=1768937074; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=9OiWidXDlc9SIxtf//Pc3bF1d2VDX0rCMR5B+TBktRE=; b=e/b7xtDRdgqOopYIWRqxopO3AW6nOjNdqvC4UrFskqXFFiEMjiOP1aK11WbL4wXuce 3zrGdnqeGDbef75vglqGNvIRZnWwL9RSJWNCORe6oLpl/+BsOiFOw1N5C3/W0tsHY9Yu IysqrBt2qOVYZ5iNvc2jRSoHAcADbBmuDicbBDa3HhWOOq4PBi6dCaNCv0Bm4JrAf8uv MHVjTiBhA+ES107PkXumsICVtCexytEchMnTqfPKy1p+/7DVnXjeP5hwN06Gu/+dpfF2 6o7PfCA5OteXUaTX6kShWx0hNmKyXMRTx3JQNnxiJxq8w/U1MCXVfR0NPJFxCBI+AjzO K4Wg== X-Forwarded-Encrypted: i=1; AJvYcCVZXABT/03HVMeXLBsXbV24KRzURICBgxdciQr9VRPyaebVIjThTt81Fx7Ouo5kVAbZmtBVQBrU0G+9@vger.kernel.org X-Gm-Message-State: AOJu0Yx9aSvN9p4mqz4orhcEOko7YeNgdeJ67YKfGfsilxOBAeBXR1Gp afiL9KygWPb8o7ccxt2gv+97Z1xtSvMe+dgfjJED3bmpzVkcZnjkKuMe X-Gm-Gg: AY/fxX6slvy8NGaQ2uy01694azvZzrBfm3WPni5wnMbusEQByxDannMlFWGwCYPK+m1 01KLtTCgegg+weZuTnMcSe4mZnOKlx8veT+McP5yhfXklGm7yTzcfPf0chv+8yUjVkpV4zoNDdy g8O0uT5NqkxH7pH/OLUjLnhUxT/z8P7XVB6hX8FG/lwHpunxSLIHX41Gpqj62IIpQZdZf6VaIMf 808lhTMj5Qypv99u7XFNVyaPYTVGKGGvX1Vd8X6u8F+8VxbYUj2oQ8liE2D8XgCk1UggNUMYY3A lrwe6ehvteb6eq4So4+8P421O9GA6cT1u9iYnD119rWk22i8kPR+Qnd5XzCmXFin/K+ij91JjpQ 4JBP4r1AKheih5ZpL5Znck6ouscovTMoxUqiLu9r6aFzvdYRnAdYXUnLLjYa7qrRTWbPm94fGCM wFZtc173O/RjW3/uVziRG5qLYrNGzeRfnjSqlUnF8T8Djre1bxZrO6vKf5FHc8ZTU= X-Received: by 2002:a05:6000:1a85:b0:431:67d:5390 with SMTP id ffacd0b85a97d-4342c554c46mr10986f8f.54.1768332274380; Tue, 13 Jan 2026 11:24:34 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd5df939sm45481323f8f.21.2026.01.13.11.24.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jan 2026 11:24:33 -0800 (PST) Date: Tue, 13 Jan 2026 19:24:32 +0000 From: David Laight To: Mark Brown Cc: linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Alexander Viro , Andreas Dilger , Christian Brauner , Kees Cook , Miklos Szeredi , OGAWA Hirofumi , Theodore Ts'o Subject: Re: [PATCH 30/44] fs: use min() or umin() instead of min_t() Message-ID: <20260113192432.25a799f4@pumpkin> In-Reply-To: <20260113183346.18ef7c74@pumpkin> References: <20251119224140.8616-1-david.laight.linux@gmail.com> <20251119224140.8616-31-david.laight.linux@gmail.com> <62097ec5-510e-4343-b111-3afee2c7b01e@sirena.org.uk> <20260113183346.18ef7c74@pumpkin> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 13 Jan 2026 18:33:46 +0000 David Laight wrote: > On Tue, 13 Jan 2026 16:56:56 +0000 > Mark Brown wrote: > > > On Wed, Nov 19, 2025 at 10:41:26PM +0000, david.laight.linux@gmail.com wrote: > > > From: David Laight > > > > > > min_t(unsigned int, a, b) casts an 'unsigned long' to 'unsigned int'. > > > Use min(a, b) instead as it promotes any 'unsigned int' to 'unsigned long' > > > and so cannot discard significant bits. > > > > This breaks an arm imx_v6_v7_defconfig build: > > I hadn't tested 32bit when I sent the patch. > It was noticed ages ago and I thought there was a patch (to fuse/file.c) that > changed the code to avoid the 64bit signed maths on 32bit. I've just sent in a patch to fix it, compile tested for 32bit x86. David > > > > In file included from : > > In function 'fuse_wr_pages', > > inlined from 'fuse_perform_write' at /home/broonie/git/bisect/fs/fuse/file.c:1347:27: > > /home/broonie/git/bisect/include/linux/compiler_types.h:630:45: error: call to '__compiletime_assert_434' declared with attribute error: min(((pos + len - 1) >> 12) - (pos >> 12) + 1, max_pages) signedness error ... ^~~~~~~~~~~~~ > > /home/broonie/git/bisect/fs/fuse/file.c:1326:16: note: in expansion of macro 'min' > > 1326 | return min(((pos + len - 1) >> PAGE_SHIFT) - (pos >> PAGE_SHIFT) + 1, > > | ^~~ >