From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BF883BC4FD for ; Thu, 15 Jan 2026 16:45:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=18.9.28.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768495535; cv=none; b=Cuys/gDX8E6FzyslrlyozmWZclcDwte7oAuzn63rX6657RJIlHZwqDslC0RUWIh7EJyJ7ZYCa8Y2o//1saYX75VtmJpBpHLDQMIa2CwILqe+PeUy/z9IyVhsdr8woD1wzo6bt561OF1dm/cFKkZsIuHBEbmWZb0di8/zw6PB6vQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768495535; c=relaxed/simple; bh=2HCmH5r8cl1tEDSLFBelNClzMABzMx70/iUher6kjok=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FXpAXqCQ0fh6iXwqvCgWxvak5Ua+/mnvcp772rWrZOeZaa4MQuYNKWcbCYpSyc5cDlUK78mgVaedFreLElP5NAQtKt6Noya8XTeoFQYqjXwUqUBeyvfPhCe65YDwy9VfAOBpvkYVZqc6YNdWtLOwGVJBm1Jrcm0mWainWEparSg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mit.edu; spf=pass smtp.mailfrom=mit.edu; dkim=pass (2048-bit key) header.d=mit.edu header.i=@mit.edu header.b=XDziS0Z6; arc=none smtp.client-ip=18.9.28.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mit.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mit.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mit.edu header.i=@mit.edu header.b="XDziS0Z6" Received: from macsyma.thunk.org ([37.140.223.84]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 60FGjBda015346 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 Jan 2026 11:45:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1768495516; bh=h5p4xDv48spuLP8tOq8jDpufYPNxaKi3ct01jIsuNmY=; h=Date:From:Subject:Message-ID:MIME-Version:Content-Type; b=XDziS0Z68J3RmCV+61gyKCx0PtMCi2SAErasQZiD/W3OYv18oUyIEd0XULXSSLx/U 4ZJEBqGtHDSN0/j63Ey0PsAIDc3lLOut9fBF8vOPkaC4P4bWosJySAs7MwXsqsSrXW AhDiOqyFPtMyAgIEy1P+DyDpkTBcag5eKyGkvObenZrIBNqr4ojAyALE5+3JzkfXgI +1iqiMCf+WpNNPHoQ2cU+jLXYbGzKgmbIYDebZLDLH2uVrutlpniKHrUMQiRSHnV0z dg1bC8awLacyy2Z0EfBJ+Qa/ikA8YpYE6ZjWOYD7OLiipYqYkF4OdbFBVDSanZf2io tTXyUqAoxf1Aw== Received: by macsyma.thunk.org (Postfix, from userid 15806) id B4C4554CC0A3; Thu, 15 Jan 2026 06:29:38 -0900 (AKST) Date: Thu, 15 Jan 2026 06:29:38 -0900 From: "Theodore Tso" To: "Darrick J. Wong" Cc: brauner@kernel.org, hch@lst.de, jack@suse.cz, linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, gabriel@krisman.be, amir73il@gmail.com Subject: Re: [PATCH 6/6] ext4: convert to new fserror helpers Message-ID: <20260115152938.GD19200@macsyma.local> References: <176826402528.3490369.2415315475116356277.stgit@frogsfrogsfrogs> <176826402693.3490369.5875002879192895558.stgit@frogsfrogsfrogs> Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <176826402693.3490369.5875002879192895558.stgit@frogsfrogsfrogs> On Mon, Jan 12, 2026 at 04:32:27PM -0800, Darrick J. Wong wrote: > From: Darrick J. Wong > > Use the new fserror functions to report metadata errors to fsnotify. > Note that ext4 inconsistently passes around negative and positive error > numbers all over the codebase, so we force them all to negative for > consistency in what we report to fserror, and fserror ensures that only > positive error numbers are passed to fanotify, per the fanotify(7) > manpage. > > Signed-off-by: "Darrick J. Wong" > Reviewed-by: Christoph Hellwig > Reviewed-by: Jan Kara Acked-by: Theodore Ts'o