From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9468D246BC5; Sat, 21 Feb 2026 19:44:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771703055; cv=none; b=FGFarW4HRxR8r3otAzk/pl8fpAWpwI8A+8hlhhBGWVpUyYNXTwSrepjOkjYZ5r7pr0TP9Kmbnh6zhlM4KqQ/4VrGFXR4sHTDblqv2ce5Gu+aFkHFk2zqKklWxhf6wN48LMFLCayKqGXDm579JanSu81F1z9BpSNxV/gaxgYdDtg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771703055; c=relaxed/simple; bh=Bz42mS4nINBFpY1zgbijQciA8eCm/Tci8KwUrRAfnlI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TlKFxrJcTtEtOu9GSCCS15WDEfnm+To60MKTiPqEWySsFTvUjWQ+8Ep3PYzCt89Ec0Dt2Qy5wiYUbEc1u01YyrYTDTXGrWVU6YH6kJ4FvZ5rkGPQYXDk+LjAGA8aVCDhyW0YWjwrtassqzVEMT9xtJf6DcyP05iaD4H3SPEV65Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XjRdJowU; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XjRdJowU" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7132C4CEF7; Sat, 21 Feb 2026 19:44:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1771703055; bh=Bz42mS4nINBFpY1zgbijQciA8eCm/Tci8KwUrRAfnlI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XjRdJowUeJujb+nzZjrFgTNx4IBh9BGCWdkMA/MqEkgwnPYHe4+yhcw7kBgiXuHXL b+EhdyDouWWjazyhDJ1Q5O9wSzVSyicEBcxxuYYRLFD/28y6cJHtDMvyd7qK+3NMm/ AWPPKJnRFdybBakZcm7WVtdB5LvYT9ykfWWagf3zN8OeqLpvhccqcRAV8C9TINvTq8 /i1YCJUCI7lugGG75mltIL8L/RyUhUywbHHGx4+2msanggMZBFoe1VdBZY7fmiP4NW kmQFclFS5So7WfVXGavsul7ECOQ5zVYH1xJ6nQij0MyQWwUXpIupJ7Z4EMdZRRddu6 9RBhEva+gcqkg== Date: Sat, 21 Feb 2026 11:44:02 -0800 From: Eric Biggers To: Christoph Hellwig Cc: "Theodore Y. Ts'o" , Jaegeuk Kim , Andreas Dilger , Chao Yu , Christian Brauner , "Darrick J. Wong" , linux-fscrypt@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 2/9] fscrypt: pass a byte offset to fscrypt_mergeable_bio Message-ID: <20260221194402.GB2536@quark> References: <20260218061531.3318130-1-hch@lst.de> <20260218061531.3318130-3-hch@lst.de> Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260218061531.3318130-3-hch@lst.de> On Wed, Feb 18, 2026 at 07:14:40AM +0100, Christoph Hellwig wrote: > Logical offsets into an inode are usually expresssed as bytes in the VFS. expresssed => expressed, in all the commit messages > /** > * fscrypt_mergeable_bio_bh() - test whether data can be added to a bio > * @bio: the bio being built up > * @next_bh: the next buffer_head for which I/O will be submitted > * > * Same as fscrypt_mergeable_bio(), except this takes a buffer_head instead of > * an inode and block number directly. Above comment needs "block number" => "file position". (Or "file offset" if you want. I think "file position" makes more sense, given that the variable is called 'pos'. Either way, "block number" is definitely wrong.) - Eric