[PATCH] ext4: replace BUG_ON with proper error handling in ext4_read_inline_folio

[PATCH] ext4: replace BUG_ON with proper error handling in ext4_read_inline_folio

[Yuto Ohnuki]

Replace BUG_ON() with proper error handling when inline data size
exceeds PAGE_SIZE. This prevents kernel panic and allows the system to
continue running while properly reporting the filesystem corruption.

The error is logged via ext4_error_inode(), the buffer head is released
to prevent memory leak, and -EFSCORRUPTED is returned to indicate
filesystem corruption.

Signed-off-by: Yuto Ohnuki <ytohnuki@amazon.com>
---
 fs/ext4/inline.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/fs/ext4/inline.c b/fs/ext4/inline.c
index 1f6bc05593df..408677fa8196 100644
--- a/fs/ext4/inline.c
+++ b/fs/ext4/inline.c
@@ -522,7 +522,15 @@ static int ext4_read_inline_folio(struct inode *inode, struct folio *folio)
 		goto out;
 
 	len = min_t(size_t, ext4_get_inline_size(inode), i_size_read(inode));
-	BUG_ON(len > PAGE_SIZE);
+
+	if (len > PAGE_SIZE) {
+		ext4_error_inode(inode, __func__, __LINE__, 0,
+				 "inline size %zu exceeds PAGE_SIZE", len);
+		ret = -EFSCORRUPTED;
+		brelse(iloc.bh);
+		goto out;
+	}
+
 	kaddr = kmap_local_folio(folio, 0);
 	ret = ext4_read_inline_data(inode, kaddr, len, &iloc);
 	kaddr = folio_zero_tail(folio, len, kaddr + len);
-- 
2.50.1




Amazon Web Services EMEA SARL, 38 avenue John F. Kennedy, L-1855 Luxembourg, R.C.S. Luxembourg B186284

Amazon Web Services EMEA SARL, Irish Branch, One Burlington Plaza, Burlington Road, Dublin 4, Ireland, branch registration number 908705

Re: [PATCH] ext4: replace BUG_ON with proper error handling in ext4_read_inline_folio

[Theodore Ts'o]

On Mon, 23 Feb 2026 12:33:46 +0000, Yuto Ohnuki wrote:
> Replace BUG_ON() with proper error handling when inline data size
> exceeds PAGE_SIZE. This prevents kernel panic and allows the system to
> continue running while properly reporting the filesystem corruption.
> 
> The error is logged via ext4_error_inode(), the buffer head is released
> to prevent memory leak, and -EFSCORRUPTED is returned to indicate
> filesystem corruption.
> 
> [...]

Applied, thanks!

[1/1] ext4: replace BUG_ON with proper error handling in ext4_read_inline_folio
      commit: e8814f7f4646aa0bba3f9e9a446b07753e87117d

Best regards,
-- 
Theodore Ts'o <tytso@mit.edu>