public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: Qing Wang <wangqing7171@gmail.com>
To: wangqing7171@gmail.com
Cc: brauner@kernel.org, jack@suse.cz, linux-ext4@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	syzbot+512459401510e2a9a39f@syzkaller.appspotmail.com,
	syzkaller-bugs@googlegroups.com, viro@zeniv.linux.org.uk
Subject: Re: [syzbot] [ext4?] INFO: task hung in filename_rmdir
Date: Sat, 28 Feb 2026 17:44:57 +0800	[thread overview]
Message-ID: <20260228094457.2253079-1-wangqing7171@gmail.com> (raw)
In-Reply-To: <20260228082942.1853224-1-wangqing7171@gmail.com>

On Sat, 28 Feb 2026 at 16:29, Qing Wang <wangqing7171@gmail.com> wrote:
> #syz test
> 
> diff --git a/fs/namei.c b/fs/namei.c
> index 58f715f7657e..34a5d49b038b 100644
> --- a/fs/namei.c
> +++ b/fs/namei.c
> @@ -5383,7 +5383,7 @@ int filename_rmdir(int dfd, struct filename *name)
>  	if (error)
>  		goto exit2;
>  
> -	dentry = start_dirop(path.dentry, &last, lookup_flags);
> +	dentry = __start_dirop(path.dentry, &last, lookup_flags, TASK_KILLABLE);
>  	error = PTR_ERR(dentry);
>  	if (IS_ERR(dentry))
>  		goto exit3;

Using interruptible locks [0] did not resolve the issue and it only improved
reliability.
 [0] __start_dirop(..., TASK_KILLABLE) -> down_write_killable_nested()

The root cause of this hung task may be a deadlock, and I've found a recent
patchset [1] that may be related. Further analysis of this patch would be
helpful.
 [1] ff7c4ea11a05 - VFS: add start_creating_killable() and start_removing_killable()
     4037d966f034 - VFS: introduce start_dirop() and end_dirop()
     5c8752729970 - VFS/nfsd/ovl: introduce start_renaming() and end_renaming()
     ac50950ca143 - VFS/ovl/smb: introduce start_renaming_dentry()
     833d2b3a072f - Add start_renaming_two_dentries()

--
Qing

      parent reply	other threads:[~2026-02-28  9:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-27 13:49 [syzbot] [ext4?] INFO: task hung in filename_rmdir syzbot
2026-02-28  8:29 ` Qing Wang
2026-02-28  9:02   ` syzbot
2026-02-28  9:44   ` Qing Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260228094457.2253079-1-wangqing7171@gmail.com \
    --to=wangqing7171@gmail.com \
    --cc=brauner@kernel.org \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=syzbot+512459401510e2a9a39f@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox