* Re: [PATCH v2] ext4: Minor fix for ext4_split_extent_zeroout()
2026-03-02 14:38 [PATCH v2] ext4: Minor fix for ext4_split_extent_zeroout() Ojaswin Mujoo
@ 2026-03-02 19:43 ` Andreas Dilger
2026-03-03 1:55 ` Baokun Li
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Andreas Dilger @ 2026-03-02 19:43 UTC (permalink / raw)
To: Ojaswin Mujoo
Cc: linux-ext4, Theodore Ts'o, Dan Carpenter,
Ritesh Harjani (IBM)
On Mar 2, 2026, at 07:38, Ojaswin Mujoo <ojaswin@linux.ibm.com> wrote:
>
> We missed storing the error which triggerd smatch warning:
>
> fs/ext4/extents.c:3369 ext4_split_extent_zeroout()
> warn: duplicate zero check 'err' (previous on line 3363)
>
> fs/ext4/extents.c
> 3361
> 3362 err = ext4_ext_get_access(handle, inode, path + depth);
> 3363 if (err)
> 3364 return err;
> 3365
> 3366 ext4_ext_mark_initialized(ex);
> 3367
> 3368 ext4_ext_dirty(handle, inode, path + depth);
> --> 3369 if (err)
> 3370 return err;
> 3371
> 3372 return 0;
> 3373 }
>
> Fix it by correctly storing the err value from ext4_ext_dirty().
>
> Link: https://lore.kernel.org/all/aYXvVgPnKltX79KE@stanley.mountain/
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Fixes: a985e07c26455 ("ext4: refactor zeroout path and handle all cases")
> Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
> Signed-off-by: Ojaswin Mujoo <ojaswin@linux.ibm.com>
Reviewed-by: Andreas Dilger <adilger@dilger.ca <mailto:adilger@dilger.ca>>
> ---
> fs/ext4/extents.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> index 3630b27e4fd7..5579e0e68c0f 100644
> --- a/fs/ext4/extents.c
> +++ b/fs/ext4/extents.c
> @@ -3365,7 +3365,7 @@ static int ext4_split_extent_zeroout(handle_t *handle, struct inode *inode,
>
> ext4_ext_mark_initialized(ex);
>
> - ext4_ext_dirty(handle, inode, path + depth);
> + err = ext4_ext_dirty(handle, inode, path + depth);
> if (err)
> return err;
>
> --
> 2.52.0
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] ext4: Minor fix for ext4_split_extent_zeroout()
2026-03-02 14:38 [PATCH v2] ext4: Minor fix for ext4_split_extent_zeroout() Ojaswin Mujoo
2026-03-02 19:43 ` Andreas Dilger
@ 2026-03-03 1:55 ` Baokun Li
2026-03-07 8:18 ` Zhang Yi
2026-03-27 4:06 ` Theodore Ts'o
3 siblings, 0 replies; 5+ messages in thread
From: Baokun Li @ 2026-03-03 1:55 UTC (permalink / raw)
To: Ojaswin Mujoo
Cc: Dan Carpenter, Ritesh Harjani (IBM), linux-ext4,
Theodore Ts'o
On 3/2/26 10:38 PM, Ojaswin Mujoo wrote:
> We missed storing the error which triggerd smatch warning:
>
> fs/ext4/extents.c:3369 ext4_split_extent_zeroout()
> warn: duplicate zero check 'err' (previous on line 3363)
>
> fs/ext4/extents.c
> 3361
> 3362 err = ext4_ext_get_access(handle, inode, path + depth);
> 3363 if (err)
> 3364 return err;
> 3365
> 3366 ext4_ext_mark_initialized(ex);
> 3367
> 3368 ext4_ext_dirty(handle, inode, path + depth);
> --> 3369 if (err)
> 3370 return err;
> 3371
> 3372 return 0;
> 3373 }
>
> Fix it by correctly storing the err value from ext4_ext_dirty().
>
> Link: https://lore.kernel.org/all/aYXvVgPnKltX79KE@stanley.mountain/
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Fixes: a985e07c26455 ("ext4: refactor zeroout path and handle all cases")
> Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
> Signed-off-by: Ojaswin Mujoo <ojaswin@linux.ibm.com>
Looks good to me.
Reviewed-by: Baokun Li <libaokun@linux.alibaba.com>
> ---
> fs/ext4/extents.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> index 3630b27e4fd7..5579e0e68c0f 100644
> --- a/fs/ext4/extents.c
> +++ b/fs/ext4/extents.c
> @@ -3365,7 +3365,7 @@ static int ext4_split_extent_zeroout(handle_t *handle, struct inode *inode,
>
> ext4_ext_mark_initialized(ex);
>
> - ext4_ext_dirty(handle, inode, path + depth);
> + err = ext4_ext_dirty(handle, inode, path + depth);
> if (err)
> return err;
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] ext4: Minor fix for ext4_split_extent_zeroout()
2026-03-02 14:38 [PATCH v2] ext4: Minor fix for ext4_split_extent_zeroout() Ojaswin Mujoo
2026-03-02 19:43 ` Andreas Dilger
2026-03-03 1:55 ` Baokun Li
@ 2026-03-07 8:18 ` Zhang Yi
2026-03-27 4:06 ` Theodore Ts'o
3 siblings, 0 replies; 5+ messages in thread
From: Zhang Yi @ 2026-03-07 8:18 UTC (permalink / raw)
To: Ojaswin Mujoo, linux-ext4, Theodore Ts'o
Cc: Dan Carpenter, Ritesh Harjani (IBM)
On 3/2/2026 10:38 PM, Ojaswin Mujoo wrote:
> We missed storing the error which triggerd smatch warning:
>
> fs/ext4/extents.c:3369 ext4_split_extent_zeroout()
> warn: duplicate zero check 'err' (previous on line 3363)
>
> fs/ext4/extents.c
> 3361
> 3362 err = ext4_ext_get_access(handle, inode, path + depth);
> 3363 if (err)
> 3364 return err;
> 3365
> 3366 ext4_ext_mark_initialized(ex);
> 3367
> 3368 ext4_ext_dirty(handle, inode, path + depth);
> --> 3369 if (err)
> 3370 return err;
> 3371
> 3372 return 0;
> 3373 }
>
> Fix it by correctly storing the err value from ext4_ext_dirty().
>
> Link: https://lore.kernel.org/all/aYXvVgPnKltX79KE@stanley.mountain/
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Fixes: a985e07c26455 ("ext4: refactor zeroout path and handle all cases")
> Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
> Signed-off-by: Ojaswin Mujoo <ojaswin@linux.ibm.com>
Looks good to me.
Reviewed-by: Zhang Yi <yi.zhang@huawei.com>
> ---
> fs/ext4/extents.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> index 3630b27e4fd7..5579e0e68c0f 100644
> --- a/fs/ext4/extents.c
> +++ b/fs/ext4/extents.c
> @@ -3365,7 +3365,7 @@ static int ext4_split_extent_zeroout(handle_t *handle, struct inode *inode,
>
> ext4_ext_mark_initialized(ex);
>
> - ext4_ext_dirty(handle, inode, path + depth);
> + err = ext4_ext_dirty(handle, inode, path + depth);
> if (err)
> return err;
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] ext4: Minor fix for ext4_split_extent_zeroout()
2026-03-02 14:38 [PATCH v2] ext4: Minor fix for ext4_split_extent_zeroout() Ojaswin Mujoo
` (2 preceding siblings ...)
2026-03-07 8:18 ` Zhang Yi
@ 2026-03-27 4:06 ` Theodore Ts'o
3 siblings, 0 replies; 5+ messages in thread
From: Theodore Ts'o @ 2026-03-27 4:06 UTC (permalink / raw)
To: linux-ext4, Ojaswin Mujoo
Cc: Theodore Ts'o, Dan Carpenter, Ritesh Harjani (IBM)
On Mon, 02 Mar 2026 20:08:11 +0530, Ojaswin Mujoo wrote:
> We missed storing the error which triggerd smatch warning:
>
> fs/ext4/extents.c:3369 ext4_split_extent_zeroout()
> warn: duplicate zero check 'err' (previous on line 3363)
>
> fs/ext4/extents.c
> 3361
> 3362 err = ext4_ext_get_access(handle, inode, path + depth);
> 3363 if (err)
> 3364 return err;
> 3365
> 3366 ext4_ext_mark_initialized(ex);
> 3367
> 3368 ext4_ext_dirty(handle, inode, path + depth);
> --> 3369 if (err)
> 3370 return err;
> 3371
> 3372 return 0;
> 3373 }
>
> [...]
Applied, thanks!
[1/1] ext4: Minor fix for ext4_split_extent_zeroout()
commit: 8c187915636da75f6223055d9933444cfa0cde83
Best regards,
--
Theodore Ts'o <tytso@mit.edu>
^ permalink raw reply [flat|nested] 5+ messages in thread