public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: Milos Nikic <nikic.milos@gmail.com>
To: jack@suse.cz
Cc: tytso@mit.edu, linux-ext4@vger.kernel.org,
	linux-kernel@vger.kernel.org, Milos Nikic <nikic.milos@gmail.com>
Subject: [PATCH v2 0/2] jbd2: audit and convert J_ASSERT usage in
Date: Mon,  2 Mar 2026 13:34:23 -0800	[thread overview]
Message-ID: <20260302213425.273187-1-nikic.milos@gmail.com> (raw)

Hello Jan and the ext4 team,

This patch series follows up on the previous discussion regarding
converting hard J_ASSERT panics into graceful journal aborts.

In v1, we addressed a specific panic on unlock. Per Jan's suggestion,
I have audited fs/jbd2/transaction.c for other low-hanging fruit
where state machine invariants are enforced by J_ASSERT inside
functions that natively support error returns.

Changes in v2:

    Patch 1: The original fix, unmodified. Collected the Reviewed-by
    tags from the v1 thread.

    Patch 2: New patch resulting from the broader audit. It systematically
    replaces J_ASSERTs with WARN_ON_ONCE and graceful -EINVAL returns
    across 6 core transaction lifecycle functions.

For Patch 2, careful attention was paid to ensuring spinlocks are safely
dropped before triggering jbd2_journal_abort(), reference counts
remain balanced, and no memory is leaked on the error paths.

Call-chain tracing confirms that upstream VFS callers (including ext4,
ocfs2, and others) already cleanly intercept these error codes to
abort the filesystem handle rather than crashing the server.

Milos Nikic (2):
  jbd2: gracefully abort instead of panicking on unlocked buffer
  jbd2: gracefully abort on transaction state corruptions

 fs/jbd2/transaction.c | 102 +++++++++++++++++++++++++++++++++---------
 1 file changed, 80 insertions(+), 22 deletions(-)

-- 
2.53.0


             reply	other threads:[~2026-03-02 21:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-02 21:34 Milos Nikic [this message]
2026-03-02 21:34 ` [PATCH v2 1/2] jbd2: gracefully abort instead of panicking on unlocked buffer Milos Nikic
2026-03-02 21:34 ` [PATCH v2 2/2] jbd2: gracefully abort on transaction state corruptions Milos Nikic
2026-03-02 23:19   ` Andreas Dilger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260302213425.273187-1-nikic.milos@gmail.com \
    --to=nikic.milos@gmail.com \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox