From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6861F382383 for ; Tue, 3 Mar 2026 10:36:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772534163; cv=none; b=bK8ek8WHMrGhvyV/If+jCFyxC4IO+Wbh/NNkxuaY/gTVXORneU6n4xxvrSlbGpwz60Nq2VGHYiUeqP1mnnHlt7jVc9iqtc2yhf4m9Yj+sJvXIb+pY+hJzhvCtL914HEsVaR2QA2hHi7fLdaT6WPn07hKKDIPBnc32MJjzM//8B8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772534163; c=relaxed/simple; bh=ud/28G3xYrWf6hhDA8l9j5Yn2n0f8oX/rNwQdYapQHM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qbnDbpE0nMqdqNCzXGJsOwIvs5ye9YWmEfTQLWVpxaCOPz8lAp5h3gygw9fOX2HUj+cfR3o1W48uK7YLkWEOqCRwDbcq4+JK5HQc94ZSPvM1+j8Ln/fCq+s7PDHlPt6UIjFnoxA+s2H2Ro/oRCauKHvio2c6R6sByB6mNZ297I8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz; spf=pass smtp.mailfrom=suse.cz; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.cz Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 447483F93A; Tue, 3 Mar 2026 10:34:45 +0000 (UTC) Authentication-Results: smtp-out1.suse.de; none Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 3639C3EA6E; Tue, 3 Mar 2026 10:34:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id WXk3DUW5pmmHFQAAD6G6ig (envelope-from ); Tue, 03 Mar 2026 10:34:45 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id E8EEFA0B6D; Tue, 3 Mar 2026 11:34:40 +0100 (CET) From: Jan Kara To: Cc: Christian Brauner , Al Viro , , Ted Tso , "Tigran A. Aivazian" , David Sterba , OGAWA Hirofumi , Muchun Song , Oscar Salvador , David Hildenbrand , linux-mm@kvack.org, linux-aio@kvack.org, Benjamin LaHaise , Jan Kara , Joel Becker , Joseph Qi , ocfs2-devel@lists.linux.dev Subject: [PATCH 20/32] ocfs2: Drop pointless sync_mapping_buffers() calls Date: Tue, 3 Mar 2026 11:34:09 +0100 Message-ID: <20260303103406.4355-52-jack@suse.cz> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260303101717.27224-1-jack@suse.cz> References: <20260303101717.27224-1-jack@suse.cz> Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1308; i=jack@suse.cz; h=from:subject; bh=ud/28G3xYrWf6hhDA8l9j5Yn2n0f8oX/rNwQdYapQHM=; b=owEBbQGS/pANAwAIAZydqgc/ZEDZAcsmYgBpprkvRii9H+t97Y2LO0i9U30mEMXFAbwMkKJma eYyaJh30hyJATMEAAEIAB0WIQSrWdEr1p4yirVVKBycnaoHP2RA2QUCaaa5LwAKCRCcnaoHP2RA 2UAuCACl44+oSXoKVpLMMjiOlzsSYJhi83OocmKg+n6aNdrCBaLaW5GL4UJkAqg3vGC4NxBSbVI dN+/zOKfB6jEEZavQOjXSs8gm3yTIzY/LUR2vkI3wARuyz6LfXqRMAOyfpEsPatajFUP3/GJvPg 9WohJCCNRhEOI5OhIJNpNBD+A9T7KF7yv/pGurqHjAasCRN7RpqBbyjc+5HjgLrHFxZll7hf36I pJY5vGfgxZ+de5q3Sy9Atdq7p8jGPM6/TvVmtqdyR1M+Dwsc4hMMlIkeCu79+XMSCWy6wD7P8j7 yHolzEvmVH4b0K1tZQ3OEumtFv/IfIvFx2yGiie9QmONH6Xd X-Developer-Key: i=jack@suse.cz; a=openpgp; fpr=93C6099A142276A28BBE35D815BC833443038D8C Content-Transfer-Encoding: 8bit X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 447483F93A X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Action: no action X-Spam-Score: -4.00 X-Spam-Level: X-Spam-Flag: NO X-Spamd-Result: default: False [-4.00 / 50.00]; REPLY(-4.00)[]; TAGGED_RCPT(0.00)[] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org ocfs2 never calls mark_buffer_dirty_inode() and thus its metadata buffers list is always empty. Drop the pointless sync_mapping_buffers() calls. CC: Joel Becker CC: Joseph Qi CC: ocfs2-devel@lists.linux.dev Signed-off-by: Jan Kara --- fs/ocfs2/dlmglue.c | 1 - fs/ocfs2/namei.c | 3 --- 2 files changed, 4 deletions(-) diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c index bd2ddb7d841d..7283bb2c5a31 100644 --- a/fs/ocfs2/dlmglue.c +++ b/fs/ocfs2/dlmglue.c @@ -3971,7 +3971,6 @@ static int ocfs2_data_convert_worker(struct ocfs2_lock_res *lockres, mlog(ML_ERROR, "Could not sync inode %llu for downconvert!", (unsigned long long)OCFS2_I(inode)->ip_blkno); } - sync_mapping_buffers(mapping); if (blocking == DLM_LOCK_EX) { truncate_inode_pages(mapping, 0); } else { diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c index 268b79339a51..1277666c77cd 100644 --- a/fs/ocfs2/namei.c +++ b/fs/ocfs2/namei.c @@ -1683,9 +1683,6 @@ static int ocfs2_rename(struct mnt_idmap *idmap, if (rename_lock) ocfs2_rename_unlock(osb); - if (new_inode) - sync_mapping_buffers(old_inode->i_mapping); - iput(new_inode); ocfs2_free_dir_lookup_result(&target_lookup_res); -- 2.51.0