Re: [PATCH v2 2/2] resize: fix memory leak when exiting normally

["Theodore Tso" <tytso@mit.edu>]

On Fri, Nov 21, 2025 at 11:36:12AM +0800, Wu Guanghao wrote:
> The main() function only releases fs when it exits through the errout or
> success_exit labels. When completes normally, it does not release fs.
> 
> Signed-off-by: Wu Guanghao <wuguanghao3@huawei.com>

I'm guessing you only tested the online resize code path?

	if (mount_flags & EXT2_MF_MOUNTED) {
		retval = online_resize_fs(fs, mtpt, &new_size, flags);
	} else {
	       ...
		retval = resize_fs(fs, &new_size, flags,
				   ((flags & RESIZE_PERCENT_COMPLETE) ?
				    resize_progress_func : 0));
	}

The reason why I ask this is that resize_fs() frees fs on the success path:

	rfs->old_fs = fs;
	...
	ext2fs_free(rfs->old_fs);
	
... although if we return when an error, we do *not* free ext2fs_free(rfs->old_fs).

So if you were to test with this applied when resizing a non-mounted
file system, I believe you'd get a double free failure.

Cheers,

							- Ted