From: Andrey Albershteyn <aalbersh@kernel.org>
To: linux-xfs@vger.kernel.org, fsverity@lists.linux.dev,
linux-fsdevel@vger.kernel.org, ebiggers@kernel.org
Cc: Andrey Albershteyn <aalbersh@kernel.org>,
hch@lst.de, linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-btrfs@vger.kernel.org, djwong@kernel.org
Subject: [PATCH v7 13/22] xfs: disable direct read path for fs-verity files
Date: Thu, 9 Apr 2026 15:13:45 +0200 [thread overview]
Message-ID: <20260409131404.1545834-14-aalbersh@kernel.org> (raw)
In-Reply-To: <20260409131404.1545834-1-aalbersh@kernel.org>
The direct path is not supported on verity files. Attempts to use direct
I/O path on such files should fall back to buffered I/O path.
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Andrey Albershteyn <aalbersh@kernel.org>
---
fs/xfs/xfs_file.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c
index a980ac5196a8..6fa9835f9531 100644
--- a/fs/xfs/xfs_file.c
+++ b/fs/xfs/xfs_file.c
@@ -282,7 +282,8 @@ xfs_file_dax_read(
struct kiocb *iocb,
struct iov_iter *to)
{
- struct xfs_inode *ip = XFS_I(iocb->ki_filp->f_mapping->host);
+ struct inode *inode = iocb->ki_filp->f_mapping->host;
+ struct xfs_inode *ip = XFS_I(inode);
ssize_t ret = 0;
trace_xfs_file_dax_read(iocb, to);
@@ -333,6 +334,14 @@ xfs_file_read_iter(
if (xfs_is_shutdown(mp))
return -EIO;
+ /*
+ * In case fs-verity is enabled, we also fallback to the buffered read
+ * from the direct read path. Therefore, IOCB_DIRECT is set and need to
+ * be cleared (see generic_file_read_iter())
+ */
+ if (fsverity_active(inode))
+ iocb->ki_flags &= ~IOCB_DIRECT;
+
if (IS_DAX(inode))
ret = xfs_file_dax_read(iocb, to);
else if (iocb->ki_flags & IOCB_DIRECT)
--
2.51.2
next prev parent reply other threads:[~2026-04-09 13:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-09 13:13 [PATCH v7 00/22] fs-verity support for XFS with post EOF merkle tree Andrey Albershteyn
2026-04-09 13:13 ` [PATCH v7 01/22] fsverity: report validation errors through fserror to fsnotify Andrey Albershteyn
2026-04-09 13:13 ` [PATCH v7 02/22] fsverity: expose ensure_fsverity_info() Andrey Albershteyn
2026-04-09 13:13 ` [PATCH v7 03/22] ovl: use core fsverity ensure info interface Andrey Albershteyn
2026-04-09 13:13 ` [PATCH v7 04/22] fsverity: generate and store zero-block hash Andrey Albershteyn
2026-04-09 13:13 ` [PATCH v7 05/22] fsverity: pass digest size and hash of the all-zeroes block to ->write Andrey Albershteyn
2026-04-09 13:13 ` [PATCH v7 06/22] fsverity: hoist pagecache_read from f2fs/ext4 to fsverity Andrey Albershteyn
2026-04-09 13:13 ` [PATCH v7 07/22] iomap: introduce IOMAP_F_FSVERITY and teach writeback to handle fsverity Andrey Albershteyn
2026-04-09 13:13 ` [PATCH v7 08/22] iomap: teach iomap to read files with fsverity Andrey Albershteyn
2026-04-09 13:13 ` [PATCH v7 09/22] iomap: introduce iomap_fsverity_write() for writing fsverity metadata Andrey Albershteyn
2026-04-09 13:13 ` [PATCH v7 10/22] xfs: introduce fsverity on-disk changes Andrey Albershteyn
2026-04-09 13:13 ` [PATCH v7 11/22] xfs: initialize fs-verity on file open Andrey Albershteyn
2026-04-09 13:13 ` [PATCH v7 12/22] xfs: don't allow to enable DAX on fs-verity sealed inode Andrey Albershteyn
2026-04-09 13:13 ` Andrey Albershteyn [this message]
2026-04-09 13:13 ` [PATCH v7 14/22] xfs: handle fsverity I/O in write/read path Andrey Albershteyn
2026-04-09 13:13 ` [PATCH v7 15/22] xfs: use read ioend for fsverity data verification Andrey Albershteyn
2026-04-09 13:13 ` [PATCH v7 16/22] xfs: add fs-verity support Andrey Albershteyn
2026-04-09 13:13 ` [PATCH v7 17/22] xfs: remove unwritten extents after preallocations in fsverity metadata Andrey Albershteyn
2026-04-09 13:13 ` [PATCH v7 18/22] xfs: add fs-verity ioctls Andrey Albershteyn
2026-04-09 13:13 ` [PATCH v7 19/22] xfs: advertise fs-verity being available on filesystem Andrey Albershteyn
2026-04-09 13:13 ` [PATCH v7 20/22] xfs: check and repair the verity inode flag state Andrey Albershteyn
2026-04-09 13:13 ` [PATCH v7 21/22] xfs: introduce health state for corrupted fsverity metadata Andrey Albershteyn
2026-04-09 13:13 ` [PATCH v7 22/22] xfs: enable ro-compat fs-verity flag Andrey Albershteyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260409131404.1545834-14-aalbersh@kernel.org \
--to=aalbersh@kernel.org \
--cc=djwong@kernel.org \
--cc=ebiggers@kernel.org \
--cc=fsverity@lists.linux.dev \
--cc=hch@lst.de \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox