From: Christian Brauner <brauner@kernel.org>
To: linux-fsdevel@vger.kernel.org
Cc: Theodore Ts'o <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Jan Kara <jack@suse.cz>,
"Ritesh Harjani (IBM)" <ritesh.list@gmail.com>,
linux-ext4@vger.kernel.org, linux-cifs@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
"Christian Brauner (Amutable)" <brauner@kernel.org>
Subject: [PATCH 0/8] super: retire sget(), convert iterators to RCU
Date: Tue, 26 May 2026 17:09:02 +0200 [thread overview]
Message-ID: <20260526-work-sget-v1-0-263f7025cedd@kernel.org> (raw)
* retire sget(): CIFS plus the two ext4 KUnit tests (extents-test,
mballoc-test) were the last in-tree callers, and all three convert
cleanly to sget_fc(). That lets sget() and its prototype come out,
taking ~60 lines that only existed to be kept in lockstep with
sget_fc() on every publish-path change.
* Walk @super_blocks and @type->fs_supers under RCU, pinned by
refcount_inc_not_zero(&sb->s_count). iterate_supers(),
iterate_supers_type(), user_get_super(), do_emergency_remount(),
filesystems_freeze() and filesystems_thaw() no longer hold sb_lock
across the cursor advance.
The conversion goes in four small steps. Drop sb_lock from
setup_bdev_super(): the {s_bdev_file, s_bdev, s_bdi,
SB_I_STABLE_WRITES} tuple is publication of immutable state, and
SB_BORN already gates every reader via super_wake()'s
smp_store_release paired with super_flags()'s smp_load_acquire. Then
convert sb->s_count to refcount_t -- mechanical, every increment is
still under sb_lock. Then switch the write-side list/hlist ops to
their _rcu variants; @super_blocks gets list_bidir_del_rcu() so the
reverse-walking iterators (filesystems_freeze, do_emergency_remount)
keep a valid ->prev on the unlinked entry, matching the canonical
pattern in kernel/nstree.c. Finally, convert the iterators themselves:
cursor advance via READ_ONCE / rcu_dereference, with the previous
entry kept pinned via its s_count across the rcu_read_unlock ->
callback -> rcu_read_lock cycle.
Signed-off-by: Christian Brauner (Amutable) <brauner@kernel.org>
---
Christian Brauner (8):
ext4: convert extents KUnit test to sget_fc()
ext4: convert mballoc KUnit test to sget_fc()
smb: client: convert cifs_smb3_do_mount() to sget_fc()
fs: retire sget()
super: drop sb_lock from setup_bdev_super() tuple publication
super: convert sb->s_count to refcount_t
super: switch list manipulation to _rcu primitives
super: convert iterators to RCU readers + refcount_inc_not_zero
fs/btrfs/super.c | 2 +-
fs/ext4/extents-test.c | 22 +++++-
fs/ext4/mballoc-test.c | 17 ++++-
fs/smb/client/cifsfs.c | 43 ++++++-----
fs/smb/client/cifsfs.h | 3 +-
fs/smb/client/cifsproto.h | 3 +-
fs/smb/client/connect.c | 5 +-
fs/smb/client/fs_context.c | 2 +-
fs/super.c | 167 ++++++++++++++---------------------------
include/linux/fs.h | 4 -
include/linux/fs/super_types.h | 3 +-
11 files changed, 127 insertions(+), 144 deletions(-)
---
base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731
change-id: 20260526-work-sget-6bc80b96cba5
next reply other threads:[~2026-05-26 15:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 15:09 Christian Brauner [this message]
2026-05-26 15:09 ` [PATCH 1/8] ext4: convert extents KUnit test to sget_fc() Christian Brauner
2026-05-26 15:09 ` [PATCH 2/8] ext4: convert mballoc " Christian Brauner
2026-05-27 0:47 ` Theodore Tso
2026-05-28 12:02 ` Christian Brauner
2026-06-03 13:52 ` Theodore Tso
2026-05-26 15:09 ` [PATCH 3/8] smb: client: convert cifs_smb3_do_mount() " Christian Brauner
2026-05-26 15:09 ` [PATCH 4/8] fs: retire sget() Christian Brauner
2026-05-26 15:09 ` [PATCH 5/8] super: drop sb_lock from setup_bdev_super() tuple publication Christian Brauner
2026-05-27 11:53 ` Christian Brauner
2026-05-26 15:09 ` [PATCH 6/8] super: convert sb->s_count to refcount_t Christian Brauner
2026-05-26 15:09 ` [PATCH 7/8] super: switch list manipulation to _rcu primitives Christian Brauner
2026-05-26 15:09 ` [PATCH 8/8] super: convert iterators to RCU readers + refcount_inc_not_zero Christian Brauner
2026-05-27 11:54 ` [PATCH 0/8] super: retire sget(), convert iterators to RCU Christian Brauner
2026-05-28 11:18 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260526-work-sget-v1-0-263f7025cedd@kernel.org \
--to=brauner@kernel.org \
--cc=adilger.kernel@dilger.ca \
--cc=jack@suse.cz \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=ritesh.list@gmail.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox