From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30B583FFACC; Tue, 26 May 2026 15:09:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779808164; cv=none; b=kgYXOLI0V79zWdysmBjQSuiUSmnik05ktUGZLAFwnW5LwePeIfZDM2vb3yaq3u2emKZRtrXf6EWC+VKI8QgbYdvImtl+Km4BVtH1onHzUabDysWJyhs1mElne687YNgFC2UwfI2Zb/UIT1O6pBWZF5+25V7NPMYpMoCaD+0U1cM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779808164; c=relaxed/simple; bh=jbv0e0UK8Foq77XiEZ0D9pv3i2mZ9QxiUA/GapR/NIc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=S+L2DXAbR34OSLgSKMLZc1P0QT9cshhNbFVvqW1NEIhhDUV5mu6RL2OXLKRk5yyPhMgmXG+K4MY5nZRafQN2esEnWoHz9xofPTFkRH2ysCWRPVelwefJFIUcLxmrtUidOlSGzf3BXB55gRXc6FCmPo4pmf5lRYjzgQkdfsU8o3s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XuHcie45; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XuHcie45" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D3ACB1F00A3C; Tue, 26 May 2026 15:09:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779808162; bh=FoBKUDf7V4kIgk99vmo9HWfzrUU9xwOAAvRzErDHe48=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=XuHcie459oFrbLxojryjTma4vC8tUJA/XIxFgsfRTHtHX6f2Xo8wmhtV6Lte5kSas uKPKE83HWjQgcAL0QffTgqdlMz0YJ7yEJwnGCMS+XEmLIhrOqtc4wxbL1/v6o0eaxw HfSt4QXH7ilV/seFlyhaV+ut5aWbIMb9GAJQ4C2fmMxDFX6BoMfdzE9ZBlXdoKRm68 FCjj+SVkNyiqK3v2tD+2iHyAG+paQHHwxBPGlrn1OBNdnfUlafPoATo9ZY5Bu6STTs CPWC4iUgQoGibhh32jp85fgU2wPTB+Bv8AjnEOpqYaziCcFd/U73nzq/7Ceea4jVtS pmUtWnG68a+BQ== From: Christian Brauner Date: Tue, 26 May 2026 17:09:04 +0200 Subject: [PATCH 2/8] ext4: convert mballoc KUnit test to sget_fc() Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260526-work-sget-v1-2-263f7025cedd@kernel.org> References: <20260526-work-sget-v1-0-263f7025cedd@kernel.org> In-Reply-To: <20260526-work-sget-v1-0-263f7025cedd@kernel.org> To: linux-fsdevel@vger.kernel.org Cc: Theodore Ts'o , Andreas Dilger , Jan Kara , "Ritesh Harjani (IBM)" , linux-ext4@vger.kernel.org, linux-cifs@vger.kernel.org, Alexander Viro , "Christian Brauner (Amutable)" X-Mailer: b4 0.16-dev-fffa9 X-Developer-Signature: v=1; a=openpgp-sha256; l=2130; i=brauner@kernel.org; h=from:subject:message-id; bh=jbv0e0UK8Foq77XiEZ0D9pv3i2mZ9QxiUA/GapR/NIc=; b=owGbwMvMwCU28Zj0gdSKO4sYT6slMWSJbp89/9VJk8zF4mdPmL50WxKySI0jauJGR6M1pbfkW xbfufVlTUcpC4MYF4OsmCKLQ7tJuNxynorNRpkaMHNYmUCGMHBxCsBEHt5nZNh3SOrHiSUTvgj3 ln45qlPYz5S21KnwxUvbxmXWawPnXxFhZNgqfm3tDKXFFnHxjy3y7u7e0BZv8mHK9Ia6qp99Umu shfkA X-Developer-Key: i=brauner@kernel.org; a=openpgp; fpr=4880B8C9BD0E5106FC070F4F7B3C391EFEA93624 Same treatment as the extents KUnit test. The mballoc test uses sget() as a thin "give me an initialized superblock" wrapper for a fake file_system_type. Move it onto sget_fc() so sget() can go away. Add a no-op mbt_init_fs_context() so fs_context_for_mount() has something to call on the fake fs_type. mbt_set() now takes a struct fs_context * (still a no-op). mbt_ext4_alloc_super_block() allocates the fc, hands it to sget_fc() and drops the fc reference once the sb is published. No functional change. Signed-off-by: Christian Brauner (Amutable) --- fs/ext4/mballoc-test.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/fs/ext4/mballoc-test.c b/fs/ext4/mballoc-test.c index 90ed505fa4b1..d90da44aadbd 100644 --- a/fs/ext4/mballoc-test.c +++ b/fs/ext4/mballoc-test.c @@ -5,6 +5,7 @@ #include #include +#include #include #include "ext4.h" @@ -63,8 +64,14 @@ static void mbt_kill_sb(struct super_block *sb) generic_shutdown_super(sb); } +static int mbt_init_fs_context(struct fs_context *fc) +{ + return 0; +} + static struct file_system_type mbt_fs_type = { .name = "mballoc test", + .init_fs_context = mbt_init_fs_context, .kill_sb = mbt_kill_sb, }; @@ -127,7 +134,7 @@ static void mbt_mb_release(struct super_block *sb) kfree(sb->s_bdev); } -static int mbt_set(struct super_block *sb, void *data) +static int mbt_set(struct super_block *sb, struct fs_context *fc) { return 0; } @@ -136,13 +143,19 @@ static struct super_block *mbt_ext4_alloc_super_block(void) { struct mbt_ext4_super_block *fsb; struct super_block *sb; + struct fs_context *fc; struct ext4_sb_info *sbi; fsb = kzalloc_obj(*fsb); if (fsb == NULL) return NULL; - sb = sget(&mbt_fs_type, NULL, mbt_set, 0, NULL); + fc = fs_context_for_mount(&mbt_fs_type, 0); + if (IS_ERR(fc)) + goto out; + + sb = sget_fc(fc, NULL, mbt_set); + put_fs_context(fc); if (IS_ERR(sb)) goto out; -- 2.47.3