From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5ECBA429CE8 for ; Mon, 27 Jul 2026 21:24:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785187475; cv=none; b=mkLnHKM/FHP4C5fIAc0oJEYMIfSMNyaudiqmnjkfGC7tNB95UhDxyUAtWKWPFibducav5U+vMRVqqnvBrWR2mAlFvxSQJCKeCUyXlUJUaksYaSRiNpN5xvkQlLVAF8mVQo8NBgRzLnZfA6YljHWakqKupaaBPG6/JZhkk0DOYlo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785187475; c=relaxed/simple; bh=37DoZPkb+1W8fWCJOdx7vJRB1ZWmqFh53cazfdVPywk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=alui4XXuAwdqzYFaR2aIQsMwf42MRi34pPXaNY2CwUDjExtxhCY+OnXuP+wF1LWP+eXTMDCxPpvWyGD0u3eGiK+J/p4iBJudl2hqUGk12xJdzxh2/YAVwGNZprGCYUGlKbmiOyK1TZ2qNVuzsf0dFm4mpby7h0AOBUg4kJThHns= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RLbnzESt; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RLbnzESt" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2caced6038eso5180615ad.0 for ; Mon, 27 Jul 2026 14:24:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785187473; x=1785792273; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=jCBfh4hnA0KRKUHFPOeo4GUfSXPKVLhLb/fiVOqAkG4=; b=RLbnzEStyKuTQwbc+Ij4DLzt3KsUz2jQXvlD/29p/YGH6+phB+0ktoA2C3qxBqfed6 jAL61DhCx2+hVUsWyw0ofZpMtBFLIWx7DIo1B1kZh65HdAD5U9nObeK3aAUeLBzhJPJZ bKUT8otzU1yfp/HfJYh6xaajy6JOIPLSc7ET9WtFCCD1ilxITDWSqRnoFMxPyVTy8GsU 1jz5D/NO94z8Dm8OpFrlTFImVvM9ch9EoZDoCo40ol2DPz0MaI5IAqjBMxepVt/IABqO NWAt2U2lmIYYOLjj64GNqC63h+KYNrDIe+9fNy1RBsOyRhiAs0QLfhsM5w7TG6ubRSzv if9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785187473; x=1785792273; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=jCBfh4hnA0KRKUHFPOeo4GUfSXPKVLhLb/fiVOqAkG4=; b=MidyPhFS3Xa6b50cVTT+OX9uSRAr131baUlN0HO4+UCe6lfvLVGUupe7nO/P7SFuli TjyUwvU9vvajTTAKANou/LCoWVByGNRfMgmCUlWUjmwpRSZ0FnJvF+hYDr5JtMaSjHAx NNOkEwVEc/IjLyjTcbu2K1vQ97Hn9GIEt9jjWOcfbhToRRNn+2bgn227vOg1lt7pelqc NuJ3T/q7Gd78etTJ32hnHWuRGYiTA/8orh0dZihg0SpQpdhn+uXXBQILTTrMHr78wFdK aCmFPwbLvvVlrbAf3mrJxucL5ZkAGkQ1+HugLLvfS8GIOsGayKPGBU5pO8NLEgByhGme FvKg== X-Forwarded-Encrypted: i=1; AHgh+RrzJqBSwFhD1j5KgqJZh0xQ/V3fKn2dYR4PUe6mcEy2g6FtrfXDomH1/PdNs3Jnb9LDUfnXcJ/g0/Pt@vger.kernel.org X-Gm-Message-State: AOJu0Yy5OKINtj+jcLptIPbSlIlxqQhPxeTG62L4QJJl3mjLih+Zx2Fq XF84RgY3Z0HwBIsZp4zjsHzePWCUHw1ZZLQMAA63p4hXTSh/tIGKNbfl X-Gm-Gg: AR+sD13Wx4tuWdCVSqysMbiH9h6blFxBVCjiGfFDvuR90imIpk2KIIN6LlscytiiWmt DSEGE2xbizocH1Bk4rw0L/o6xlzqEf5hGR92r/vFIXQmsPWpl3R9FKmqL0NauYj6siMhpXFXGfp xi9c87n2Ieh057w9vOKK3uZMUftYDwFwDXmODe7qnZlyM/2N3F3+efcRaEAGeYKBWnLizKxCUkx Xx4gcWvK2io8VSEaRgXW0ZDPNUGtUerIXdAm3PsBspLFg+Bc0X7vdVTMnQTa1OGJTnQgKvXkqeq PjB1NmhjFNmcWuhrytBWG6D436G9ByHQGF8H7FevTLATU9PIV2WY6t94Sp/kv3rv1r16drpjNUY Af8h0ulBGYUKuKvkLOyDXqnT5wnmR5C8pShCkCZA6Iq772RkVQE5ykyfP0uk95n28hS+Ew04DVk a8Qa39hxHfso4C5JkkaeFz8n8Muc/0JfrwF/o2y9of9dzWUU9e2ZsUhQ== X-Received: by 2002:a17:903:1745:b0:2cb:402:70cc with SMTP id d9443c01a7336-2d0122483c1mr3309335ad.28.1785187472633; Mon, 27 Jul 2026 14:24:32 -0700 (PDT) Received: from localhost ([2a03:2880:ff:71::]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cfde5e333bsm40730925ad.30.2026.07.27.14.24.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2026 14:24:32 -0700 (PDT) From: Joanne Koong To: Christian Brauner , hch@lst.de, "Darrick J . Wong" , linux-fsdevel@vger.kernel.org Cc: changfengnan@bytedance.com, kbusch@kernel.org, Matthew Wilcox , Jan Kara , Jonathan Corbet , David Sterba , Gao Xiang , Namjae Jeon , tytso@mit.edu, Jaegeuk Kim , Miklos Szeredi , Andreas Gruenbacher , Mikulas Patocka , Hyunchul Lee , Konstantin Komarov , Carlos Maiolino , Damien Le Moal , libaokun@linux.alibaba.com, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org Subject: [PATCH v4 03/21] iomap: use GFP_NOWAIT when application for iomap_dio_simple allocations Date: Mon, 27 Jul 2026 14:17:40 -0700 Message-ID: <20260727211758.1116539-4-joannelkoong@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260727211758.1116539-1-joannelkoong@gmail.com> References: <20260727211758.1116539-1-joannelkoong@gmail.com> Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Christoph Hellwig For non-blocking iocbs we should avoid blocking allocation where possible, so switch to a GFP_NOWAIT allocation here. Reviewed-by: Darrick J. Wong Reviewed-by: Joanne Koong Signed-off-by: Joanne Koong Signed-off-by: Christoph Hellwig --- fs/iomap/direct-io.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c index 36c976cf0848..5c28124b9f02 100644 --- a/fs/iomap/direct-io.c +++ b/fs/iomap/direct-io.c @@ -986,6 +986,7 @@ static void iomap_dio_simple_end_io(struct bio *bio) ssize_t __iomap_dio_read_simple(struct kiocb *iocb, struct iov_iter *iter, struct iomap_iter *iomi) { + gfp_t gfp = (iomi->flags & IOMAP_NOWAIT) ? GFP_NOWAIT : GFP_KERNEL; struct iomap_dio_simple *sr; unsigned int alignment; struct bio *bio; @@ -1015,7 +1016,11 @@ ssize_t __iomap_dio_read_simple(struct kiocb *iocb, struct iov_iter *iter, bio = bio_alloc_bioset(iomi->iomap.bdev, bio_iov_vecs_to_alloc(iter, BIO_MAX_VECS), - REQ_OP_READ, GFP_KERNEL, &iomap_dio_simple_pool); + REQ_OP_READ, gfp, &iomap_dio_simple_pool); + if (!bio) { + ret = -EAGAIN; + goto out_dio_end; + } sr = container_of(bio, struct iomap_dio_simple, bio); sr->iocb = iocb; sr->dio_flags = 0; -- 2.52.0