Re: [RFC PATCH] ext4: cacheline-align inode cache to avoid false sharing

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Fragile performance optimization relying on configuration-dependent struct layout
--

commit 7acd8c0fa63f737f049b6c32ef756e22fa1aeabb
Author: JonasZhou-oc <jonaszhou-oc@zhaoxin.com>

ext4: cacheline-align inode cache to avoid false sharing

This patch adds SLAB_HWCACHE_ALIGN to the ext4 inode cache creation flags.
The goal is to align the embedded vfs_inode.i_rwsem to a cache-line boundary
to avoid false sharing with other metadata.

Link: https://lore.kernel.org/linux-fsdevel/CAGudoHFgtM8Px4mRNM_fsmi3=vAyCMPC3FBCzk5uE7ma7fdbdQ@mail.gmail.com/

> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index bca0dc87d0b7c..49ac97af19945 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -1519,7 +1519,8 @@ static int __init init_inodecache(void)
>  	ext4_inode_cachep = kmem_cache_create("ext4_inode_cache",
>  				sizeof(struct ext4_inode_info),
>  				&args,
> -				SLAB_RECLAIM_ACCOUNT | SLAB_ACCOUNT);
> +				SLAB_RECLAIM_ACCOUNT | SLAB_ACCOUNT |
> +				SLAB_HWCACHE_ALIGN);

[Severity: Medium]
Will this reliably align i_rwsem to a cache-line boundary across different
kernel configurations?

The offset of i_rwsem within struct ext4_inode_info is highly dependent on
kernel configurations. Options like CONFIG_LOCKDEP or CONFIG_DEBUG_SPINLOCK
can alter the sizes of preceding spinlock_t and struct rw_semaphore fields.

While SLAB_HWCACHE_ALIGN ensures the start of struct ext4_inode_info is
cache-line aligned, the varying internal offset of i_rwsem means it may still
arbitrarily span cache-line boundaries or share a line with heavily modified
metadata in other builds.

Does this optimization risk uniformly imposing memory overhead while failing to
provide the performance benefit on varying configurations?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260827074334.616360-1-jonaszhou-oc@zhaoxin.com?part=1