From: sashiko-bot@kernel.org
To: ThangNN99 <ngocthang2710.1999@gmail.com>
Cc: tytso@mit.edu, linux-ext4@vger.kernel.org
Subject: Re: [PATCH v2 v2] ext4: avoid buffer/folio lock inversion in __ext4_get_inode_loc()
Date: Mon, 07 Sep 2026 15:55:28 +0000 [thread overview]
Message-ID: <20260907155528.DBF7F1F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <20260907155017.75543-1-ngocthang2710.1999@gmail.com>
> __ext4_get_inode_loc() looks up the inode bitmap bh while holding the
> lock on the inode table bh:
>
> __ext4_get_inode_loc()
> lock_buffer(itable block)
> sb_getblk(inode bitmap block)
> __find_get_block_nonatomic()
> folio_lock(bdev folio for bitmap block)
>
> whereas block_read_full_folio() (e.g. userspace reading the bdev inode
> directly) takes the same two locks in the opposite order:
>
> block_read_full_folio()
> folio_lock(some folio)
> lock_buffer(bh in folio)
> [ ... ]
>
> Reported-by: syzbot+03afbb29537f0336b7ad@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=03afbb29537f0336b7ad
> Reviewed-by: Jan Kara <jack@suse.cz>
> Signed-off-by: ThangNN99 <ngocthang2710.1999@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260907155017.75543-1-ngocthang2710.1999@gmail.com?part=1
next prev parent reply other threads:[~2026-09-07 15:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-06 10:48 [PATCH] ext4: avoid buffer/folio lock inversion in __ext4_get_inode_loc() ThangNN99
2026-09-06 11:03 ` sashiko-bot
2026-09-07 9:15 ` Jan Kara
2026-09-07 15:50 ` ThangNN99
2026-09-07 15:50 ` [PATCH v2 v2] " ThangNN99
2026-09-07 15:55 ` sashiko-bot [this message]
2026-09-11 17:02 ` [PATCH " Nguyen Ngoc Thang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260907155528.DBF7F1F00A3A@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=ngocthang2710.1999@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox