From: sashiko-bot@kernel.org
To: 781735889@qq.com
Cc: tytso@mit.edu, linux-ext4@vger.kernel.org
Subject: Re: [PATCH v3] ext4: propagate errors from fast commit i_blocks replay
Date: Tue, 15 Sep 2026 02:04:31 +0000 [thread overview]
Message-ID: <20260915020431.DC0711F000FF@smtp.kernel.org> (raw)
In-Reply-To: <tencent_ECF4DA918377A7A0D8863B860B0F3025C106@qq.com>
> From: lty <781735889@qq.com>
>
> ext4_ext_replay_set_iblocks() breaks out of its mapping loop when
> ext4_map_blocks() fails, but then continues with a partial block count
> and unconditionally returns success. The fast commit replay caller also
> ignores the helper return value.
>
> Stop the count immediately on mapping errors, leave i_blocks unchanged,
> and propagate the failure to abort inode replay.
>
> Fixes: 8016e29f4362 ("ext4: fast commit recovery path")
> Signed-off-by: lty <781735889@qq.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/tencent_ECF4DA918377A7A0D8863B860B0F3025C106@qq.com?part=1
next prev parent reply other threads:[~2026-09-15 2:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 1:57 [PATCH v3] ext4: propagate errors from fast commit i_blocks replay 781735889
2026-09-15 2:04 ` sashiko-bot [this message]
2026-09-15 10:09 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260915020431.DC0711F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=781735889@qq.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox