From: Eric Biggers <ebiggers@kernel.org>
To: Niklas Cassel <cassel@kernel.org>
Cc: Matthias Goergens <matthias.goergens@gmail.com>,
Theodore Ts'o <tytso@mit.edu>, Jan Kara <jack@suse.cz>,
linux-ext4@vger.kernel.org, dlemoal@kernel.org
Subject: Re: [PATCH] MAINTAINERS: name the ext4 dev branch
Date: Fri, 25 Sep 2026 11:43:57 -0700 [thread overview]
Message-ID: <20260925184357.GA2060@quark> (raw)
In-Reply-To: <arZx1GSVS61EFaiQ@ryzen>
On Fri, Sep 25, 2026 at 03:06:28PM +0200, Niklas Cassel wrote:
> Hello Eric,
>
> On Wed, Sep 23, 2026 at 09:00:30PM -0700, Eric Biggers wrote:
> > On Thu, Sep 24, 2026 at 11:32:00AM +0800, Matthias Goergens wrote:
> > > For the entries, my plan is to start with the roughly 160 T: lines
> > > that name a repository whose HEAD is already in mainline while
> > > linux-next pulls a different branch from it: one small patch per
> > > repository, sent to that entry's maintainers as its own thread. I'd
> > > send a few first, to maintainers who usually respond quickly, and then
> > > the rest in larger batches once the first ones have landed or drawn
> > > comments. You know far better than I do how maintainers take this
> > > kind of tree-wide cleanup, so I'd welcome your view on that approach
> > > before I start.
> >
> > Explicitly documenting branches in MAINTAINERS sounds good, but in
> > addition to that, HEAD should also be made to point to the correct
> > branch (at least in repositories where there is only one main
> > development branch). This can be done using gitolite's symbolic-ref
> > command: https://korg.docs.kernel.org/gitolite/index.html#symbolic-ref
>
> For the record, there is no need to use a gitolite specific command,
> regular:
>
> $ git remote set-head libata for-next
>
> works.
>
>
> Damien and I (co-maintainers for libata) had this discussion offline a few
> months ago when Sashiko was constantly using the wrong branch.
>
> Assuming that you have a 'fixes' branch and a 'for-next' branch, which
> branch should be default?
Probably the one that most commits go through for that subsystem. For
most subsystems that is for-next (or equivalent) rather than fixes (or
equivalent).
> The branch to use depends on the type of change it is.
>
> And many maintainers can go a very long time without either merging in
> 'fixes' to 'for-next', or rebasing 'for-next', so critical fixes might
> be lacking from 'for-next'.
I rebase mine at least once per release, and I think other maintainers
should do that too. But yes, that can happen.
Really, people sending patches should pass the --base option to 'git
format-patch', and in the vast majority of cases should use a base
commit that's in mainline or linux-next. Then it's straightforward for
anyone (or anything) to apply the patches without any knowledge of any
subsystem specific development branches.
(Note that can work even if there are prerequisite patches that aren't
in the base yet. They'll show up as prerequisite-patch-id lines.)
In the few cases where that isn't enough the sender should be super
clear how to apply the patches.
The fact that it's often so difficult to apply patches is a very
frustrating and mostly unnecessary problem in kernel development. (And
I run into it a lot, since when reviewing patches I like to apply them
and review them in proper context, not just work from the email only.)
- Eric
next prev parent reply other threads:[~2026-09-25 18:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 10:17 [PATCH] MAINTAINERS: name the ext4 dev branch Matthias Goergens
2026-09-23 10:44 ` Jan Kara
2026-09-24 3:14 ` Theodore Tso
2026-09-24 3:32 ` Matthias Goergens
2026-09-24 4:00 ` Eric Biggers
2026-09-24 8:30 ` Matthias Goergens
2026-09-24 8:53 ` Jan Kara
2026-09-25 13:06 ` Niklas Cassel
2026-09-25 18:43 ` Eric Biggers [this message]
2026-09-26 6:11 ` Matthias Goergens
2026-09-26 15:57 ` Niklas Cassel
2026-10-01 11:25 ` Matthias Goergens
2026-10-08 15:32 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260925184357.GA2060@quark \
--to=ebiggers@kernel.org \
--cc=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=matthias.goergens@gmail.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox