From: Eric Biggers <ebiggers@kernel.org>
To: fsverity@lists.linux.dev
Cc: linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org,
Christoph Hellwig <hch@lst.de>,
stable@vger.kernel.org
Subject: Re: [PATCH] fsverity: Set S_VERITY only after rollback is no longer possible
Date: Wed, 28 Oct 2026 11:07:42 -0700 [thread overview]
Message-ID: <20261028180742.GD1876@quark> (raw)
In-Reply-To: <20261025204807.122875-1-ebiggers@kernel.org>
On Sun, Oct 25, 2026 at 01:48:07PM -0700, Eric Biggers wrote:
> However, ext4 and btrfs can roll back verity after they set S_VERITY,
> causing a use-after-free.
>
> Fix that by making ext4 and btrfs set S_VERITY only after rollback is no
> longer possible. On failure, don't roll back S_VERITY, but do roll back
> the filesystem-specific verity flag.
Applied to https://git.kernel.org/pub/scm/fs/fsverity/linux.git/log/?h=for-current
Acks from the ext4 and btrfs maintainers would be appreciated.
- Eric
prev parent reply other threads:[~2026-10-28 18:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-25 20:48 [PATCH] fsverity: Set S_VERITY only after rollback is no longer possible Eric Biggers
2026-10-25 21:01 ` sashiko-bot
2026-10-27 15:08 ` Christoph Hellwig
2026-10-28 18:07 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261028180742.GD1876@quark \
--to=ebiggers@kernel.org \
--cc=fsverity@lists.linux.dev \
--cc=hch@lst.de \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox