Linux EXT4 FS development
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Tal Zussman <tz2294@columbia.edu>
Cc: fstests@vger.kernel.org, Zorro Lang <zlang@kernel.org>,
	Christoph Hellwig <hch@lst.de>,
	linux-ext4@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
	"Darrick J. Wong" <djwong@kernel.org>, Jan Kara <jack@suse.cz>,
	Brian Foster <bfoster@redhat.com>
Subject: Re: [PATCH v2 2/3] common/rc: pass -V 1 when probing pwrite and pread -U
Date: Wed, 11 Nov 2026 17:47:29 +0100	[thread overview]
Message-ID: <20261111164729.GD18355@lst.de> (raw)
In-Reply-To: <20261107-dontcache-test-v2-2-7655bf08d6d1@columbia.edu>

On Sat, Nov 07, 2026 at 09:19:40PM -0500, Tal Zussman wrote:
> xfs_io refuses pwritev2() and preadv2() flags unless -V is given, so
> probing -U without it always fails. Pass -V 1 for -U in both the pwrite
> and pread cases.

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

  reply	other threads:[~2026-11-11 16:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-08  2:19 [PATCH v2 0/3] fstests: test that RWF_DONTCACHE I/O drops its folios Tal Zussman
2026-11-08  2:19 ` [PATCH v2 1/3] common/rc: probe pread options with a real read Tal Zussman
2026-11-08  2:19 ` [PATCH v2 2/3] common/rc: pass -V 1 when probing pwrite and pread -U Tal Zussman
2026-11-11 16:47   ` Christoph Hellwig [this message]
2026-11-08  2:19 ` [PATCH v2 3/3] generic/810: check that RWF_DONTCACHE I/O drops its folios Tal Zussman
2026-11-09 14:10   ` Brian Foster
2026-11-09 18:37     ` Tal Zussman
2026-11-11 16:47   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261111164729.GD18355@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=bfoster@redhat.com \
    --cc=djwong@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tz2294@columbia.edu \
    --cc=zlang@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox