public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: akpm@linux-foundation.org
Cc: dhowells@redhat.com, cmm@us.ibm.com, tytso@mit.edu,
	linux-ext4@vger.kernel.org, jean-noel.cordenner@bull.net
Subject: Re: [patch 3/8] 64-bit i_version: afs fixes
Date: Thu, 29 Nov 2007 22:23:45 +0000	[thread overview]
Message-ID: <21098.1196375025@redhat.com> (raw)
In-Reply-To: <200711292052.lATKqnvt006831@imap1.linux-foundation.org>

akpm@linux-foundation.org wrote:

> -	_leave(" = 0 { vn=%u u=%u } -> { ino=%lu v=%lu }",
> +	_leave(" = 0 { vn=%u u=%u } -> { ino=%lu v=%llu }",
>  	       fid.vnode,
>  	       fid.unique,
>  	       dentry->d_inode->i_ino,
> -	       dentry->d_inode->i_version);
> +	       (unsigned long long)dentry->d_inode->i_version);

Hmmm...  In AFS's case this is overkill...  The value contained in i_version
is going to be a 32-bit number because that's all the protocol supports.

David

      reply	other threads:[~2007-11-29 22:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-29 20:52 [patch 3/8] 64-bit i_version: afs fixes akpm
2007-11-29 22:23 ` David Howells [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21098.1196375025@redhat.com \
    --to=dhowells@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=cmm@us.ibm.com \
    --cc=jean-noel.cordenner@bull.net \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox