From: Daeho Jeong <daeho.jeong@samsung.com>
To: "tytso@mit.edu" <tytso@mit.edu>, jack@suse.cz
Cc: Daeho Jeong <daeho.jeong@samsung.com>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>
Subject: Re: Question about ext4_free_blocks() Behavior for Per-File Data Journaling Mode
Date: Tue, 08 Dec 2015 07:02:20 +0000 (GMT) [thread overview]
Message-ID: <2137019115.413281449558139670.JavaMail.weblogic@epmlwas04b> (raw)
> Hi. I have a question about ext4_free_blocks() behavior for per-file data journaling
> mode. AFAIUI, in ext4_free_blocks(), it doesn't invoke ext4_forget() function for
> data blocks of a per-file data journaling enabled file, because all the data blocks
> of the file are not linked to the block device's address space of the file, but the
> address space of the inode of the file, so any data blocks of the file cannot be
> found by sb_find_get_block() function. It seems a bug, but I am not sure.
> Is this a problem?
I just answer my own question. It was a silly question, because all the data buffers
of per-file data journalled file are forgotten by jbd2_journal_invalidatepage() in advance
of invoking ext4_free_blocks().
Anyway, the revoke operation to the data blocks is still missing in ext4_free_blocks().
I will fix this problem. :-)
next reply other threads:[~2015-12-08 7:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 7:02 Daeho Jeong [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-10-14 4:39 Question about ext4_free_blocks() Behavior for Per-File Data Journaling Mode Daeho Jeong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2137019115.413281449558139670.JavaMail.weblogic@epmlwas04b \
--to=daeho.jeong@samsung.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox