From: Tadeusz Struk <tadeusz.struk@linaro.org>
To: linux-ext4@vger.kernel.org
Cc: Andreas Dilger <adilger.kernel@dilger.ca>,
Ritesh Harjani <riteshh@linux.ibm.com>,
stable@vger.kernel.org, linux-kernel@vger.kernel.org,
syzbot+7a806094edd5d07ba029@syzkaller.appspotmail.com,
tytso@mit.edu
Subject: Re: [PATCH v2] ext4: check if offset+length is valid in fallocate
Date: Mon, 28 Mar 2022 09:12:27 -0700 [thread overview]
Message-ID: <21f3fd84-2de9-646c-4d0c-94007a996c70@linaro.org> (raw)
In-Reply-To: <20220315215439.269122-1-tadeusz.struk@linaro.org>
On 3/15/22 14:54, Tadeusz Struk wrote:
> Syzbot found an issue [1] in ext4_fallocate().
> The C reproducer [2] calls fallocate(), passing size 0xffeffeff000ul,
> and offset 0x1000000ul, which, when added together exceed the disk size,
> and trigger a BUG in ext4_ind_remove_space() [3].
> According to the comment doc in ext4_ind_remove_space() the 'end' block
> parameter needs to be one block after the last block to remove.
> In the case when the BUG is triggered it points to the last block on
> a 4GB virtual disk image. This is calculated in
> ext4_ind_remove_space() in [4].
> This patch adds a check that ensure the length + offest to be
> within the valid range and returns -ENOSPC error code in case
> it is invalid.
Hi,
Any feedback on this?
--
Thanks,
Tadeusz
next prev parent reply other threads:[~2022-03-28 16:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 21:54 [PATCH v2] ext4: check if offset+length is valid in fallocate Tadeusz Struk
2022-03-22 16:37 ` Ira Weiny
2022-03-22 17:42 ` Tadeusz Struk
2022-03-28 16:12 ` Tadeusz Struk [this message]
2022-03-31 14:43 ` Theodore Ts'o
2022-03-31 18:03 ` Tadeusz Struk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21f3fd84-2de9-646c-4d0c-94007a996c70@linaro.org \
--to=tadeusz.struk@linaro.org \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=riteshh@linux.ibm.com \
--cc=stable@vger.kernel.org \
--cc=syzbot+7a806094edd5d07ba029@syzkaller.appspotmail.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).